Skip to content
This repository has been archived by the owner on Dec 22, 2020. It is now read-only.

improve package json #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

improve package json #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c98c64
add typings, typescript as dev deps, use standard prepublish script
lipp Apr 7, 2017
db629d1
adapt contribution guide
lipp Apr 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,26 +9,34 @@ git clone https://github.com/Microsoft/PowerBI-Cli.git powerbi-cli

Navigate to the cloned directory

Install typescript and local dependencies - you need to run it only once.
Install dependencies and dev-dependencies.
```
npm run precontrib
npm i
```

## Build:

```
npm run contrib
npm run prepublish
```

## Running the CLI
## Install CLI from local repository:

In root git repository directory:

```
npm i -g
```

## Running the CLI without installation

Navigate to `/bin` directory and run cli file using node.

```
cd bin & node cli
```

## Running specific command:
### Running specific command:

Navigate to `/bin` directory and run specific cli file using node.
Example:
Expand Down
8 changes: 5 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
"main": "./index.js",
"typings": "./index.d.ts",
"scripts": {
"precontrib": "npm install -g typings typescript && npm install",
"contrib": "typings install && tsc"
"prepublish": "typings install && tsc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calling tsc after installing it via devDependencies does not work for me.
am I missing something here? maybe it worked for you because you have typescript installed globally?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsc is important for incremental build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll check it out...

},
"author": "PowerBI <[email protected]> (https://dev.powerbi.com)",
"license": "MIT",
Expand All @@ -20,7 +19,10 @@
"ms-rest": "^1.12.0",
"powerbi-api": "^1.2"
},
"devDependencies": {},
"devDependencies": {
"typescript": "^2.2.2",
"typings": "^2.1.0"
},
"repository": {
"type": "git",
"url": "git+https://github.com/Microsoft/PowerBI-Cli.git"
Expand Down