[ZoomIt]Fix transparent draw after changing another setting #37042
+14
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxmsft
approved these changes
Jan 23, 2025
drawbyperpetual
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
While testing the release candidate with ZoomIt, we found an error that caused the draw mode to not work after changing a Setting.
It turns out we were missing the code that sets opacity after loading the settings from PowerToys.
This PR adds that code.
This PR also identifies some other settings that are used internally by ZoomIt as state only and removes them from the settings the Settings application knows, so that we don't keep status for those while manipulating other settings and end up overwriting the changes the running ZoomIt has done to that internal state.
Validation Steps Performed
1 - Start ZoomIt.
2 - Verify Draw works.
3 - Change any Setting.
4 - Verify Draw still works. (Before this fix it would try to draw with transparent ink)
5 - Change pen color (Press G or B in draw mode for Green or Blue, for example)
6 - Try to change any Setting.
7 - Enter draw mode and verify your color change is still remembered.