-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not use JSX.ElementChildrenAttribute under jsx: react-jsx or jsx: react-jsxdev
#60880
Open
uhyo
wants to merge
3
commits into
microsoft:main
Choose a base branch
from
uhyo:fix-60572
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
tests/baselines/reference/jsxNamespaceNoElementChildrenAttributeReactJsx(jsx=react-jsx).js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| //// [tests/cases/compiler/jsxNamespaceNoElementChildrenAttributeReactJsx.tsx] //// | ||
|
|
||
| //// [jsx.d.ts] | ||
| declare namespace JSX { | ||
| interface IntrinsicElements { | ||
| h1: { children: string } | ||
| } | ||
|
|
||
| type Element = string; | ||
| } | ||
|
|
||
| //// [test.tsx] | ||
| const Title = (props: { children: string }) => <h1>{props.children}</h1>; | ||
|
|
||
| const element = <Title>Hello, world!</Title>; | ||
|
|
||
| //// [jsx-runtime.ts] | ||
| export {}; | ||
| //// [jsx-dev-runtime.ts] | ||
| export {}; | ||
|
|
||
| //// [jsx-runtime.js] | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| //// [test.js] | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| var jsx_runtime_1 = require("/jsx/jsx-runtime"); | ||
| var Title = function (props) { return (0, jsx_runtime_1.jsx)("h1", { children: props.children }); }; | ||
| var element = (0, jsx_runtime_1.jsx)(Title, { children: "Hello, world!" }); | ||
| //// [jsx-dev-runtime.js] | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
40 changes: 40 additions & 0 deletions
40
...baselines/reference/jsxNamespaceNoElementChildrenAttributeReactJsx(jsx=react-jsx).symbols
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| //// [tests/cases/compiler/jsxNamespaceNoElementChildrenAttributeReactJsx.tsx] //// | ||
|
|
||
| === /jsx.d.ts === | ||
| declare namespace JSX { | ||
| >JSX : Symbol(JSX, Decl(jsx.d.ts, 0, 0)) | ||
|
|
||
| interface IntrinsicElements { | ||
| >IntrinsicElements : Symbol(IntrinsicElements, Decl(jsx.d.ts, 0, 23)) | ||
|
|
||
| h1: { children: string } | ||
| >h1 : Symbol(IntrinsicElements.h1, Decl(jsx.d.ts, 1, 31)) | ||
| >children : Symbol(children, Decl(jsx.d.ts, 2, 9)) | ||
| } | ||
|
|
||
| type Element = string; | ||
| >Element : Symbol(Element, Decl(jsx.d.ts, 3, 3)) | ||
| } | ||
|
|
||
| === /test.tsx === | ||
| const Title = (props: { children: string }) => <h1>{props.children}</h1>; | ||
| >Title : Symbol(Title, Decl(test.tsx, 0, 5)) | ||
| >props : Symbol(props, Decl(test.tsx, 0, 15)) | ||
| >children : Symbol(children, Decl(test.tsx, 0, 23)) | ||
| >h1 : Symbol(JSX.IntrinsicElements.h1, Decl(jsx.d.ts, 1, 31)) | ||
| >props.children : Symbol(children, Decl(test.tsx, 0, 23)) | ||
| >props : Symbol(props, Decl(test.tsx, 0, 15)) | ||
| >children : Symbol(children, Decl(test.tsx, 0, 23)) | ||
| >h1 : Symbol(JSX.IntrinsicElements.h1, Decl(jsx.d.ts, 1, 31)) | ||
|
|
||
| const element = <Title>Hello, world!</Title>; | ||
| >element : Symbol(element, Decl(test.tsx, 2, 5)) | ||
| >Title : Symbol(Title, Decl(test.tsx, 0, 5)) | ||
| >Title : Symbol(Title, Decl(test.tsx, 0, 5)) | ||
|
|
||
| === /jsx/jsx-runtime.ts === | ||
|
|
||
| export {}; | ||
| === /jsx/jsx-dev-runtime.ts === | ||
|
|
||
| export {}; |
56 changes: 56 additions & 0 deletions
56
...s/baselines/reference/jsxNamespaceNoElementChildrenAttributeReactJsx(jsx=react-jsx).types
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| //// [tests/cases/compiler/jsxNamespaceNoElementChildrenAttributeReactJsx.tsx] //// | ||
|
|
||
| === /jsx.d.ts === | ||
| declare namespace JSX { | ||
| interface IntrinsicElements { | ||
| h1: { children: string } | ||
| >h1 : { children: string; } | ||
| > : ^^^^^^^^^^^^ ^^^ | ||
| >children : string | ||
| > : ^^^^^^ | ||
| } | ||
|
|
||
| type Element = string; | ||
| >Element : string | ||
| > : ^^^^^^ | ||
| } | ||
|
|
||
| === /test.tsx === | ||
| const Title = (props: { children: string }) => <h1>{props.children}</h1>; | ||
| >Title : (props: { children: string; }) => string | ||
| > : ^ ^^ ^^^^^^^^^^^ | ||
| >(props: { children: string }) => <h1>{props.children}</h1> : (props: { children: string; }) => string | ||
| > : ^ ^^ ^^^^^^^^^^^ | ||
| >props : { children: string; } | ||
| > : ^^^^^^^^^^^^ ^^^ | ||
| >children : string | ||
| > : ^^^^^^ | ||
| ><h1>{props.children}</h1> : string | ||
| > : ^^^^^^ | ||
| >h1 : any | ||
| > : ^^^ | ||
| >props.children : string | ||
| > : ^^^^^^ | ||
| >props : { children: string; } | ||
| > : ^^^^^^^^^^^^ ^^^ | ||
| >children : string | ||
| > : ^^^^^^ | ||
| >h1 : any | ||
| > : ^^^ | ||
|
|
||
| const element = <Title>Hello, world!</Title>; | ||
| >element : string | ||
| > : ^^^^^^ | ||
| ><Title>Hello, world!</Title> : string | ||
| > : ^^^^^^ | ||
| >Title : (props: { children: string; }) => string | ||
| > : ^ ^^ ^^^^^^^^^^^ | ||
| >Title : (props: { children: string; }) => string | ||
| > : ^ ^^ ^^^^^^^^^^^ | ||
|
|
||
| === /jsx/jsx-runtime.ts === | ||
|
|
||
| export {}; | ||
| === /jsx/jsx-dev-runtime.ts === | ||
|
|
||
| export {}; |
35 changes: 35 additions & 0 deletions
35
...s/baselines/reference/jsxNamespaceNoElementChildrenAttributeReactJsx(jsx=react-jsxdev).js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| //// [tests/cases/compiler/jsxNamespaceNoElementChildrenAttributeReactJsx.tsx] //// | ||
|
|
||
| //// [jsx.d.ts] | ||
| declare namespace JSX { | ||
| interface IntrinsicElements { | ||
| h1: { children: string } | ||
| } | ||
|
|
||
| type Element = string; | ||
| } | ||
|
|
||
| //// [test.tsx] | ||
| const Title = (props: { children: string }) => <h1>{props.children}</h1>; | ||
|
|
||
| const element = <Title>Hello, world!</Title>; | ||
|
|
||
| //// [jsx-runtime.ts] | ||
| export {}; | ||
| //// [jsx-dev-runtime.ts] | ||
| export {}; | ||
|
|
||
| //// [jsx-dev-runtime.js] | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| //// [test.js] | ||
| "use strict"; | ||
| var _this = this; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| var jsx_dev_runtime_1 = require("/jsx/jsx-dev-runtime"); | ||
| var _jsxFileName = "/test.tsx"; | ||
| var Title = function (props) { return (0, jsx_dev_runtime_1.jsxDEV)("h1", { children: props.children }, void 0, false, { fileName: _jsxFileName, lineNumber: 1, columnNumber: 47 }, _this); }; | ||
| var element = (0, jsx_dev_runtime_1.jsxDEV)(Title, { children: "Hello, world!" }, void 0, false, { fileName: _jsxFileName, lineNumber: 3, columnNumber: 16 }, this); | ||
| //// [jsx-runtime.js] | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
40 changes: 40 additions & 0 deletions
40
...elines/reference/jsxNamespaceNoElementChildrenAttributeReactJsx(jsx=react-jsxdev).symbols
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| //// [tests/cases/compiler/jsxNamespaceNoElementChildrenAttributeReactJsx.tsx] //// | ||
|
|
||
| === /jsx.d.ts === | ||
| declare namespace JSX { | ||
| >JSX : Symbol(JSX, Decl(jsx.d.ts, 0, 0)) | ||
|
|
||
| interface IntrinsicElements { | ||
| >IntrinsicElements : Symbol(IntrinsicElements, Decl(jsx.d.ts, 0, 23)) | ||
|
|
||
| h1: { children: string } | ||
| >h1 : Symbol(IntrinsicElements.h1, Decl(jsx.d.ts, 1, 31)) | ||
| >children : Symbol(children, Decl(jsx.d.ts, 2, 9)) | ||
| } | ||
|
|
||
| type Element = string; | ||
| >Element : Symbol(Element, Decl(jsx.d.ts, 3, 3)) | ||
| } | ||
|
|
||
| === /test.tsx === | ||
| const Title = (props: { children: string }) => <h1>{props.children}</h1>; | ||
| >Title : Symbol(Title, Decl(test.tsx, 0, 5)) | ||
| >props : Symbol(props, Decl(test.tsx, 0, 15)) | ||
| >children : Symbol(children, Decl(test.tsx, 0, 23)) | ||
| >h1 : Symbol(JSX.IntrinsicElements.h1, Decl(jsx.d.ts, 1, 31)) | ||
| >props.children : Symbol(children, Decl(test.tsx, 0, 23)) | ||
| >props : Symbol(props, Decl(test.tsx, 0, 15)) | ||
| >children : Symbol(children, Decl(test.tsx, 0, 23)) | ||
| >h1 : Symbol(JSX.IntrinsicElements.h1, Decl(jsx.d.ts, 1, 31)) | ||
|
|
||
| const element = <Title>Hello, world!</Title>; | ||
| >element : Symbol(element, Decl(test.tsx, 2, 5)) | ||
| >Title : Symbol(Title, Decl(test.tsx, 0, 5)) | ||
| >Title : Symbol(Title, Decl(test.tsx, 0, 5)) | ||
|
|
||
| === /jsx/jsx-runtime.ts === | ||
|
|
||
| export {}; | ||
| === /jsx/jsx-dev-runtime.ts === | ||
|
|
||
| export {}; |
56 changes: 56 additions & 0 deletions
56
...aselines/reference/jsxNamespaceNoElementChildrenAttributeReactJsx(jsx=react-jsxdev).types
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| //// [tests/cases/compiler/jsxNamespaceNoElementChildrenAttributeReactJsx.tsx] //// | ||
|
|
||
| === /jsx.d.ts === | ||
| declare namespace JSX { | ||
| interface IntrinsicElements { | ||
| h1: { children: string } | ||
| >h1 : { children: string; } | ||
| > : ^^^^^^^^^^^^ ^^^ | ||
| >children : string | ||
| > : ^^^^^^ | ||
| } | ||
|
|
||
| type Element = string; | ||
| >Element : string | ||
| > : ^^^^^^ | ||
| } | ||
|
|
||
| === /test.tsx === | ||
| const Title = (props: { children: string }) => <h1>{props.children}</h1>; | ||
| >Title : (props: { children: string; }) => string | ||
| > : ^ ^^ ^^^^^^^^^^^ | ||
| >(props: { children: string }) => <h1>{props.children}</h1> : (props: { children: string; }) => string | ||
| > : ^ ^^ ^^^^^^^^^^^ | ||
| >props : { children: string; } | ||
| > : ^^^^^^^^^^^^ ^^^ | ||
| >children : string | ||
| > : ^^^^^^ | ||
| ><h1>{props.children}</h1> : string | ||
| > : ^^^^^^ | ||
| >h1 : any | ||
| > : ^^^ | ||
| >props.children : string | ||
| > : ^^^^^^ | ||
| >props : { children: string; } | ||
| > : ^^^^^^^^^^^^ ^^^ | ||
| >children : string | ||
| > : ^^^^^^ | ||
| >h1 : any | ||
| > : ^^^ | ||
|
|
||
| const element = <Title>Hello, world!</Title>; | ||
| >element : string | ||
| > : ^^^^^^ | ||
| ><Title>Hello, world!</Title> : string | ||
| > : ^^^^^^ | ||
| >Title : (props: { children: string; }) => string | ||
| > : ^ ^^ ^^^^^^^^^^^ | ||
| >Title : (props: { children: string; }) => string | ||
| > : ^ ^^ ^^^^^^^^^^^ | ||
|
|
||
| === /jsx/jsx-runtime.ts === | ||
|
|
||
| export {}; | ||
| === /jsx/jsx-dev-runtime.ts === | ||
|
|
||
| export {}; |
20 changes: 20 additions & 0 deletions
20
tests/cases/compiler/jsxNamespaceNoElementChildrenAttributeReactJsx.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| //@jsx: react-jsx,react-jsxdev | ||
| //@jsxImportSource: /jsx | ||
| //@filename: /jsx.d.ts | ||
| declare namespace JSX { | ||
| interface IntrinsicElements { | ||
| h1: { children: string } | ||
| } | ||
|
|
||
| type Element = string; | ||
| } | ||
|
|
||
| //@filename: /test.tsx | ||
| const Title = (props: { children: string }) => <h1>{props.children}</h1>; | ||
|
|
||
| const element = <Title>Hello, world!</Title>; | ||
|
|
||
| //@filename: /jsx/jsx-runtime.ts | ||
| export {}; | ||
| //@filename: /jsx/jsx-dev-runtime.ts | ||
| export {}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be good to add a test case that defines
ElementChildrenAttributeas something different thanchildrento verify that it's ignored in favor of "hard-coded"childrenThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! Added a test case.