Better handle filesystem optional features. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filesystems (e.g. ext4, xfs) sometimes receive new features. When these features are enabled, anything that loads the filesystem (e.g. kernel, grub, etc.) must support the new feature or it will refuse to load it. When formatting a new partition, there are a few considerations for if a filesystem feature should be enabled: - Does the version of mkfs support that feature? - Does the build host kernel support that feature? - Does the target OS support that feature? This change ensure that all these considerations are handled correctly for the ext4 and xfs filesystem types.
liulanze
reviewed
Jan 7, 2025
liulanze
previously approved these changes
Jan 8, 2025
PawelWMS
reviewed
Jan 8, 2025
PawelWMS
reviewed
Jan 8, 2025
PawelWMS
reviewed
Jan 8, 2025
mfrw
reviewed
Jan 9, 2025
| @@ -433,7 +423,7 @@ func WaitForDevicesToSettle() error { | |||
| } | |||
|
|
|||
| // CreatePartitions creates partitions on the specified disk according to the disk config | |||
| func CreatePartitions(diskDevPath string, disk configuration.Disk, rootEncryption configuration.RootEncryption, | |||
| func CreatePartitions(targetOs targetos.TargetOs, diskDevPath string, disk configuration.Disk, rootEncryption configuration.RootEncryption, | |||
There was a problem hiding this comment.
An opinion here, since this is a new repo, there is a chance that as time goes on, we might end up adding more and more options here.
How about we have a struct with default values, and on top of that struct we implement a method CreateParititions.
This might help us in only modifying the code at a single place where we have the initial struct and the rest of the code might not need any modifications :)
Just an opinion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filesystems (e.g. ext4, xfs) sometimes receive new features. When these features are enabled, anything that loads the filesystem (e.g. kernel, grub, etc.) must support the new feature or it will refuse to load it.
When formatting a new partition, there are a few considerations for if a filesystem feature should be enabled:
This change ensure that all these considerations are handled correctly for the ext4 and xfs filesystem types.
Checklist