Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ipykernel version to 6.5.0 #26132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gy-mate
Copy link
Contributor

@gy-mate gy-mate commented Jan 4, 2025

This might fix #26075.

Dear reviewer: please thoroughly test this PR (I haven't tested it) by going through the steps described here in order to avoid this happening again! Thank you in advance!

@kburtram
Copy link
Member

kburtram commented Jan 9, 2025

This change is unfortunately breaking the CI build. I need to do a different update to the Python Notebook feature this week, so I can take a look at this at the same time.

Run yarn --frozen-lockfile --network-timeout 180000
yarn install v1.22.22
$ node build/npm/preinstall.js
[1/4] Resolving packages...
[2/4] Fetching packages...
warning [email protected]: The engine "pnpm" appears to be invalid.
[3/4] Linking dependencies...
warning " > @angular/[email protected]" has incorrect peer dependency "zone.js@^0.8.4".
warning "@microsoft/1ds-core-js > @microsoft/[email protected].[15](https://github.com/microsoft/azuredatastudio/actions/runs/12610909612/job/35343906713?pr=26132#step:10:16)" has unmet peer dependency "tslib@*".
warning " > [email protected]" has incorrect peer dependency "zone.js@^0.7.2".
warning " > [email protected]" has unmet peer dependency "jquery-ui@>=1.8.0".
warning " > [email protected]" has unmet peer dependency "jquery.event.drag@>=2.3.0".
warning " > [email protected]" has unmet peer dependency "postcss@^8.0.0".
warning " > [email protected]" has unmet peer dependency "@bazel/bazelisk@>=1.7.5".
warning " > [email protected]" has unmet peer dependency "@bazel/concatjs@>=5.3.0".
[4/4] Building fresh packages...
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
error /home/runner/work/azuredatastudio/azuredatastudio/node_modules/keytar: Command failed.
Exit code: 1
Command: prebuild-install || npm run build
Arguments: 
Directory: /home/runner/work/azuredatastudio/azuredatastudio/node_modules/keytar
Output:
> [email protected] build
> node-gyp rebuild

gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using node@20.[17](https://github.com/microsoft/azuredatastudio/actions/runs/12610909612/job/35343906713?pr=26132#step:10:18).0 | linux | x64
gyp info find Python using Python version 3.11.11 found at "/opt/hostedtoolcache/Python/3.11.11/x64/bin/python3"

gyp info spawn /opt/hostedtoolcache/Python/3.11.11/x64/bin/python3
gyp info spawn args [
gyp info spawn args '/opt/hostedtoolcache/node/20.17.0/x64/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args 'binding.gyp',
gyp info spawn args '-f',
gyp info spawn args 'make',
gyp info spawn args '-I',
gyp info spawn args '/home/runner/work/azuredatastudio/azuredatastudio/node_modules/keytar/build/config.gypi',
gyp info spawn args '-I',
gyp info spawn args '/opt/hostedtoolcache/node/20.17.0/x64/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
gyp info spawn args '-I',
gyp info spawn args '/home/runner/.cache/node-gyp/30.5.1/include/node/common.gypi',
gyp info spawn args '-Dlibrary=shared_library',
gyp info spawn args '-Dvisibility=default',
gyp info spawn args '-Dnode_root_dir=/home/runner/.cache/node-gyp/30.5.1',
gyp info spawn args '-Dnode_gyp_dir=/opt/hostedtoolcache/node/20.17.0/x64/lib/node_modules/npm/node_modules/node-gyp',
gyp info spawn args '-Dnode_lib_file=/home/runner/.cache/node-gyp/30.5.1/<(target_arch)/node.lib',
gyp info spawn args '-Dmodule_root_dir=/home/runner/work/azuredatastudio/azuredatastudio/node_modules/keytar',
gyp info spawn args '-Dnode_engine=v8',
gyp info spawn args '--depth=.',
gyp info spawn args '--no-parallel',
gyp info spawn args '--generator-output',
gyp info spawn args 'build',
gyp info spawn args '-Goutput_dir=.'
gyp info spawn args ]
Package libsecret-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsecret-1.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libsecret-1', required by 'virtual:world', not found
gyp: Call to 'pkg-config --cflags libsecret-1' returned exit status 1 while in binding.gyp. while trying to load binding.gyp
gyp ERR! configure error 
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack at ChildProcess.<anonymous> (/opt/hostedtoolcache/node/20.17.0/x64/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:297:[18](https://github.com/microsoft/azuredatastudio/actions/runs/12610909612/job/35343906713?pr=26132#step:10:19))
gyp ERR! stack at ChildProcess.emit (node:events:519:28)
gyp ERR! stack at ChildProcess._handle.onexit (node:internal/child_process:294:12)
gyp ERR! System Linux 6.8.0-1017-azure
gyp ERR! command "/opt/hostedtoolcache/node/[20](https://github.com/microsoft/azuredatastudio/actions/runs/12610909612/job/35343906713?pr=26132#step:10:21).17.0/x64/bin/node" "/opt/hostedtoolcache/node/20.17.0/x64/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/runner/work/azuredatastudio/azuredatastudio/node_modules/keytar
gyp ERR! node -v v20.17.0
gyp ERR! node-gyp -v v10.1.0
gyp ERR! not ok
Error: Process completed with exit code 1.
``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to activate Python or PowerShell Kernel failure
2 participants