Adding HTTP(S) over HTTP(S) proxy support to add accounts. #26137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This'll be huge if this fixes the proxy authentication issues! Can you update the description with information about how you've validated that this fixes the proxy issues? |
kburtram
reviewed
Jan 9, 2025
| if (proxy) { | ||
| const agent = this.createProxyAgent(requestUrl, proxy, httpConfig["proxyStrictSSL"]); | ||
|
|
||
| if (proxy.includes("https")) { |
There was a problem hiding this comment.
should this be "starts with", or there's other stuff before the https://
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #25990,
This PR adds support for the following proxy configurations by setting a proxy agent manually.
HTTP over HTTP
HTTP over HTTPS
HTTPS over HTTP
HTTPS over HTTPS
In Axios, there's a bug with the way it reads the HTTPS_PROXY and HTTP_PROXY environment variables and this in turn is preventing accounts from being added in Azure Data Studio when the user is in a proxy environment and attempting to add an account.