Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add chromedriver binary in its updated version #4596

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

JhontSouth
Copy link
Collaborator

#minor

Description

This PR avoids the Command Injection vulnerability by removing the chromedriver package and replaces its functionality using its binary to perform the browser unit tests.

Specific Changes

  • Removed chromedriver package from browser-functional tests.
  • Added chromedriver binary into browser-functional.
  • Modified server path of nigthwatch chrome configuration.
  • Removed unnecessary jobs related to chromedriver in the browser-tests-build-ci pipeline.

Testing

The following image shows the browser-tests-build-ci pipeline running successfully after the changes.
image

@JhontSouth JhontSouth requested a review from a team as a code owner January 9, 2024 14:54
@coveralls
Copy link

coveralls commented Jan 9, 2024

Pull Request Test Coverage Report for Build 7462724718

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.511%

Totals Coverage Status
Change from base Build 7448575785: 0.0%
Covered Lines: 20408
Relevant Lines: 22872

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 8a30768 into main Jan 9, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/chromedriver-local-binary branch January 9, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants