fix: [#4684] ESLint issues in botbuilder-dialogs-adaptive-testing

libraries/botbuilder-dialogs-adaptive-testing/package.json

@@ -7,7 +7,7 @@
     "build": "tsc -b",
     "clean": "rimraf _ts3.4 lib tsconfig.tsbuildinfo",
     "depcheck": "depcheck --config ../../.depcheckrc",
-    "lint": "eslint .",
+    "lint": "eslint . --config ../../eslint.config.cjs",
     "postbuild": "downlevel-dts lib _ts3.4/lib --checksum",
     "test": "npm-run-all build test:mocha",
     "test:mocha": "mocha tests/*.test.js",
@@ -32,7 +32,6 @@
     "botbuilder-dialogs-adaptive-runtime-core": "4.1.6",
     "botbuilder-dialogs-declarative": "4.1.6",
     "botbuilder-stdlib": "4.1.6",
-    "eslint-plugin-only-warn": "^1.1.0",
     "murmurhash-js": "^1.0.0",
     "nock": "^13.5.5",
     "url-parse": "^1.5.10",

libraries/botbuilder-dialogs-adaptive-testing/src/actions/assertCondition.ts

@@ -42,7 +42,6 @@ export class AssertCondition<O extends object = {}> extends Dialog<O> implements
      *
      * @param property Properties that extend RecognizerConfiguration.
      * @returns Expression converter.
-     *
      */
     getConverter(property: keyof AssertConditionConfiguration): Converter | ConverterFactory {
         switch (property) {

libraries/botbuilder-dialogs-adaptive-testing/src/adaptiveTestBotComponent.ts

@@ -61,7 +61,7 @@ export class AdaptiveTestBotComponent extends BotComponent {
                         { kind: AssertTelemetryContains.$kind, type: AssertTelemetryContains },
                     ];
                 },
-            })
+            }),
         );
     }
 }

libraries/botbuilder-dialogs-adaptive-testing/src/httpRequestMocks/httpResponseMock.ts

@@ -27,18 +27,13 @@ export enum ResponseStatusCode {
     NoContent = 204,
     ResetContent = 205,
     PartialContent = 206,
-    Ambiguous = 300,
     MultipleChoices = 300,
-    Moved = 301,
     MovedPermanently = 301,
     Found = 302,
-    Redirect = 302,
-    RedirectMethod = 303,
     SeeOther = 303,
     NotModified = 304,
     UseProxy = 305,
     Unused = 306,
-    RedirectKeepVerb = 307,
     TemporaryRedirect = 307,
     BadRequest = 400,
     Unauthorized = 401,
@@ -65,6 +60,30 @@ export enum ResponseStatusCode {
     ServiceUnavailable = 503,
     GatewayTimeout = 504,
     HttpVersionNotSupported = 505,
+
+    // Synonyms
+    /* eslint-disable @typescript-eslint/no-duplicate-enum-values */
+    /**
+     * Synonym for MultipleChoices.
+     */
+    Ambiguous = 300,
+    /**
+     * Synonym for MovedPermanently.
+     */
+    Moved = 301,
+    /**
+     * Synonym for Found.
+     */
+    Redirect = 302,
+    /**
+     * Synonym for SeeOther.
+     */
+    RedirectMethod = 303,
+    /**
+     * Synonym for TemporaryRedirect.
+     */
+    RedirectKeepVerb = 307,
+    /* eslint-enable @typescript-eslint/no-duplicate-enum-values */
 }
 
 /**

libraries/botbuilder-dialogs-adaptive-testing/src/mocks/mockHttpRequestMiddleware.ts

@@ -71,7 +71,7 @@ export class MockHttpRequestMiddleware implements Middleware {
         const origins = new Set<string>(
             this._httpRequestMocks
                 .filter((mock) => mock instanceof HttpRequestSequenceMock)
-                .map((mock: HttpRequestSequenceMock) => parse(mock.url).origin)
+                .map((mock: HttpRequestSequenceMock) => parse(mock.url).origin),
         );
 
         // call fallback functions if mocks not catched

libraries/botbuilder-dialogs-adaptive-testing/src/mocks/mockLuisExtensions.ts

@@ -52,7 +52,7 @@ function flattenSettings(settings: Record<string, any>): Record<string, string>
  */
 export function useMockLuisSettings(
     directory: string,
-    endpoint = 'https://westus.api.cognitive.microsoft.com'
+    endpoint = 'https://westus.api.cognitive.microsoft.com',
 ): Record<string, string> {
     const files = fs.readdirSync(directory);
     const settings = files

libraries/botbuilder-dialogs-adaptive-testing/src/mocks/mockLuisLoader.ts

@@ -24,7 +24,10 @@ export class MockLuisLoader implements CustomDeserializer<MockLuisRecognizer, Lu
      * @param {ResourceExplorer} _resourceExplorer ResourceExplorer to use.
      * @param {Record<string, string>} _configuration Configuration to use.
      */
-    constructor(private _resourceExplorer: ResourceExplorer, private _configuration?: Record<string, string>) {}
+    constructor(
+        private _resourceExplorer: ResourceExplorer,
+        private _configuration?: Record<string, string>,
+    ) {}
 
     /**
      * @param config Config to recognize intents and entities in a users utterance.
@@ -36,7 +39,7 @@ export class MockLuisLoader implements CustomDeserializer<MockLuisRecognizer, Lu
         const externalEntityRecognizer = config.externalEntityRecognizer;
         if (typeof externalEntityRecognizer === 'string') {
             recognizer.externalEntityRecognizer = this._resourceExplorer.loadType<Recognizer>(
-                `${externalEntityRecognizer}.dialog`
+                `${externalEntityRecognizer}.dialog`,
             );
         }
         let name = recognizer.applicationId.toString();

libraries/botbuilder-dialogs-adaptive-testing/src/mocks/mockLuisRecognizer.ts

@@ -85,7 +85,7 @@ export class MockLuisRecognizer extends Recognizer {
         dialogContext: DialogContext,
         activity: Activity,
         telemetryProperties?: Record<string, string>,
-        telemetryMetrics?: Record<string, number>
+        telemetryMetrics?: Record<string, number>,
     ): Promise<RecognizerResult> {
         const options = this._recognizer.recognizerOptions(dialogContext);
         options.includeAPIResults = true;
@@ -164,7 +164,7 @@ export class MockLuisRecognizer extends Recognizer {
     private async _fallback(
         _request: HttpRequestMessage,
         utterance: string,
-        options: LuisRecognizerOptionsV3
+        options: LuisRecognizerOptionsV3,
     ): Promise<HttpResponseMessage> {
         const responsePath: string = this._responsePath(utterance, options);
         if (fs.existsSync(responsePath)) {

libraries/botbuilder-dialogs-adaptive-testing/src/testAction.ts

@@ -22,6 +22,6 @@ export abstract class TestAction extends Configurable {
     abstract execute(
         adapter: TestAdapter,
         callback: (context: TurnContext) => Promise<void>,
-        inspector?: Inspector
+        inspector?: Inspector,
     ): void;
 }

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/assertNoActivity.ts

@@ -43,7 +43,7 @@ export class AssertNoActivity extends TestAction implements AssertNoActivityConf
     async execute(
         adapter: TestAdapter,
         _callback: (context: TurnContext) => Promise<void>,
-        _inspector?: Inspector
+        _inspector?: Inspector,
     ): Promise<void> {
         if (adapter.activeQueue.length > 0) {
             throw new Error(this.getConditionDescription());

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/assertReply.ts

@@ -49,7 +49,7 @@ export class AssertReply extends AssertReplyActivity implements AssertReplyConfi
             if (this.exact) {
                 if (activity.type == ActivityTypes.Message && activity.text != this.text) {
                     throw new Error(
-                        this.description || `Text ${activity.text} didn't match expected text: ${this.text}`
+                        this.description || `Text ${activity.text} didn't match expected text: ${this.text}`,
                     );
                 }
             } else {
@@ -58,7 +58,7 @@ export class AssertReply extends AssertReplyActivity implements AssertReplyConfi
                     !activity.text.toLowerCase().trim().includes(this.text.toLowerCase().trim())
                 ) {
                     throw new Error(
-                        this.description || `Text ${activity.text} didn't match expected text: ${this.text}`
+                        this.description || `Text ${activity.text} didn't match expected text: ${this.text}`,
                     );
                 }
             }

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/assertReplyActivity.ts

@@ -75,10 +75,10 @@ export class AssertReplyActivity extends TestAction implements AssertReplyActivi
     async execute(
         testAdapter: TestAdapter,
         _callback: (context: TurnContext) => Promise<any>,
-        _inspector?: Inspector
+        _inspector?: Inspector,
     ): Promise<any> {
         const start = new Date();
-        /* eslint-disable no-constant-condition */
+
         while (true) {
             const current = new Date();
 

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/assertReplyOneOf.ts

@@ -67,7 +67,7 @@ export class AssertReplyOneOf extends AssertReplyActivity implements AssertReply
 
         if (!found) {
             throw new Error(
-                this.description || `Text ${activity.text} didn't match one of expected text: ${this.text.join('\n')}`
+                this.description || `Text ${activity.text} didn't match one of expected text: ${this.text.join('\n')}`,
             );
         }
 

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/assertTelemetryContains.ts

@@ -42,7 +42,7 @@ export class AssertTelemetryContains extends TestAction implements AssertTelemet
     async execute(
         _adapter: TestAdapter,
         _callback: (context: TurnContext) => Promise<void>,
-        inspector?: Inspector
+        inspector?: Inspector,
     ): Promise<void> {
         if (inspector) {
             await inspector((dc) => {

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/customEvent.ts

@@ -40,7 +40,7 @@ export class CustomEvent<T = unknown> extends TestAction implements CustomEventC
     async execute(
         testAdapter: TestAdapter,
         callback: (context: TurnContext) => Promise<void>,
-        _inspector?: Inspector
+        _inspector?: Inspector,
     ): Promise<void> {
         if (!this.name) {
             throw Error('You must define the event name.');

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/memoryAssertions.ts

@@ -42,7 +42,7 @@ export class MemoryAssertions extends TestAction implements MemoryAssertionsConf
     async execute(
         _adapter: TestAdapter,
         _callback: (context: TurnContext) => Promise<void>,
-        inspector?: Inspector
+        inspector?: Inspector,
     ): Promise<void> {
         if (inspector) {
             await inspector((dc) => {

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/setProperties.ts

@@ -70,7 +70,7 @@ export class SetProperties extends TestAction {
     async execute(
         _adapter: TestAdapter,
         _callback: (context: TurnContext) => Promise<void>,
-        inspector?: Inspector
+        inspector?: Inspector,
     ): Promise<void> {
         if (inspector) {
             await inspector((dc) => {

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/userActivity.ts

@@ -42,7 +42,7 @@ export class UserActivity extends TestAction implements UserActivityConfiguratio
     async execute(
         testAdapter: TestAdapter,
         callback: (context: TurnContext) => Promise<void>,
-        _inspector?: Inspector
+        _inspector?: Inspector,
     ): Promise<void> {
         if (!this.activity) {
             throw new Error('You must define one of Text of Activity properties');

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/userConversationUpdate.ts

@@ -41,7 +41,7 @@ export class UserConversationUpdate extends TestAction implements UserConversati
     async execute(
         testAdapter: TestAdapter,
         callback: (context: TurnContext) => Promise<void>,
-        _inspector?: Inspector
+        _inspector?: Inspector,
     ): Promise<void> {
         const activity = testAdapter.makeActivity();
         activity.type = ActivityTypes.ConversationUpdate;

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/userDelay.ts

@@ -35,7 +35,7 @@ export class UserDelay extends TestAction implements UserDelayConfiguration {
     async execute(
         _testAdapter: TestAdapter,
         _callback: (context: TurnContext) => Promise<any>,
-        _inspector?: Inspector
+        _inspector?: Inspector,
     ): Promise<void> {
         await Promise.resolve((resolve) => setTimeout(resolve, this.timespan));
     }

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/userSays.ts

@@ -46,7 +46,7 @@ export class UserSays extends TestAction implements UserSaysConfiguration {
     async execute(
         testAdapter: TestAdapter,
         callback: (context: TurnContext) => Promise<void>,
-        _inspector?: Inspector
+        _inspector?: Inspector,
     ): Promise<void> {
         if (!this.text) {
             throw new Error('You must define the text property');

libraries/botbuilder-dialogs-adaptive-testing/src/testActions/userTyping.ts

@@ -36,7 +36,7 @@ export class UserTyping extends Configurable implements TestAction, UserTypingCo
     async execute(
         testAdapter: TestAdapter,
         callback: (context: TurnContext) => Promise<any>,
-        _inspector?: Inspector
+        _inspector?: Inspector,
     ): Promise<any> {
         const typing = testAdapter.makeActivity();
         typing.type = ActivityTypes.Typing;

libraries/botbuilder-dialogs-adaptive-testing/src/testScript.ts

@@ -218,7 +218,7 @@ export class TestScript extends Configurable implements TestScriptConfiguration
             const activity = TurnContext.applyConversationReference(
                 { name: 'inspector', type: ActivityTypes.Event },
                 adapter.conversation,
-                true
+                true,
             );
             await adapter.processActivity(activity, async (turnContext) => await di.inspect(turnContext, inspector));
         };

libraries/botbuilder-dialogs-adaptive-testing/tests/action.test.js

@@ -123,6 +123,7 @@ class SetSkillBotFrameworkClientMiddleware {
 
 describe('ActionTests', function () {
     let resourceExplorer;
+
     before(function () {
         resourceExplorer = makeResourceExplorer('ActionTests', LanguageGenerationBotComponent);
     });
@@ -158,7 +159,7 @@ describe('ActionTests', function () {
             undefined,
             undefined,
             new SetSkillConversationIdFactoryBaseMiddleware(),
-            new SetSkillBotFrameworkClientMiddleware()
+            new SetSkillBotFrameworkClientMiddleware(),
         );
     });
 
@@ -214,7 +215,7 @@ describe('ActionTests', function () {
             undefined,
             undefined,
             new SetSkillConversationIdFactoryBaseMiddleware(),
-            new SetSkillBotFrameworkClientMiddleware()
+            new SetSkillBotFrameworkClientMiddleware(),
         );
     });
 
@@ -400,8 +401,8 @@ describe('ActionTests', function () {
                     Object.assign({}, [
                         { text: 'Joe is 52', age: 52 },
                         { text: 'text', age: 11 },
-                    ])
-                )
+                    ]),
+                ),
             )
             .reply(200, 'array');
         nock('http://foo.com')

libraries/botbuilder-dialogs-adaptive-testing/tests/actionScope.test.js

@@ -3,6 +3,7 @@ const { makeResourceExplorer } = require('./utils');
 
 describe('ActionScopeTests', function () {
     let resourceExplorer;
+
     before(function () {
         resourceExplorer = makeResourceExplorer('ActionScopeTests');
     });

libraries/botbuilder-dialogs-adaptive-testing/tests/adaptiveDialog.test.js

@@ -3,6 +3,7 @@ const { makeResourceExplorer } = require('./utils');
 
 describe('AdaptiveDialogTests', function () {
     let resourceExplorer;
+
     before(function () {
         resourceExplorer = makeResourceExplorer('AdaptiveDialogTests');
     });
@@ -103,7 +104,7 @@ describe('AdaptiveDialogTests', function () {
         await TestUtils.runTestScript(resourceExplorer, 'AdaptiveDialog_NestedRecognizers');
     });
 
-    it('PropertySetInInterruption', async function () {
+    it('PropertyBotInterruption', async function () {
         await TestUtils.runTestScript(resourceExplorer, 'AdaptiveDialog_ParentBotInterruption');
     });
 

libraries/botbuilder-dialogs-adaptive-testing/tests/conditionals.test.js

@@ -5,6 +5,7 @@ const { LuisAdaptiveRecognizer, LuisBotComponent } = require('botbuilder-ai');
 
 describe('ConditionalsTests', function () {
     let resourceExplorer;
+
     before(function () {
         resourceExplorer = makeResourceExplorer('ConditionalsTests');
     });
@@ -24,7 +25,7 @@ describe('ConditionalsTests', function () {
         resourceExplorer.registerType(
             LuisAdaptiveRecognizer.$kind,
             MockLuisRecognizer,
-            new MockLuisLoader(resourceExplorer, config)
+            new MockLuisLoader(resourceExplorer, config),
         );
         await TestUtils.runTestScript(resourceExplorer, 'ChooseEntity', undefined, config);
     });

libraries/botbuilder-dialogs-adaptive-testing/tests/crossTrainedRecognizerSet.test.js

@@ -49,12 +49,13 @@ const getDialogContext = (testName, text, locale = 'en-us') => {
             from: bot,
             locale,
         }),
-        {}
+        {},
     );
 };
 
 describe('CrossTrainedRecognizerSetTests', function () {
     let resourceExplorer;
+
     before(function () {
         resourceExplorer = makeResourceExplorer('CrossTrainedRecognizerSetTests');
     });