Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: Update d3-format package #4842

Merged
merged 1 commit into from
Jan 13, 2025
Merged

bump: Update d3-format package #4842

merged 1 commit into from
Jan 13, 2025
+19 −12

Conversation

JhontSouth
Copy link
Collaborator

@JhontSouth JhontSouth commented Jan 10, 2025 •
edited
Loading

#minor

Description

This PR updates the d3-format package to the latest version and applies the necessary configuration to keep working in adaptive-expressions.

Specific Changes

  • Updated d3-format to version ^3.1.0.
  • Added prebuild scripts to adaptive-expressions to use tsup to compile ESM-only package.
  • Updated imports of d3-format in every class.

Testing

The following image shows the adaptive-expressions unit tests working after the updates.
image

@JhontSouth JhontSouth requested a review from a team as a code owner January 10, 2025 14:03
@coveralls
Copy link

coveralls commented Jan 10, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12710970627

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.618%
Totals Coverage Status
Change from base Build 12635070225: 0.0%
Covered Lines: 20517
Relevant Lines: 23098
💛 - Coveralls

@ceciliaavila ceciliaavila mentioned this pull request Jan 10, 2025
Closed
@tracyboehrer tracyboehrer merged commit 428a1cd into main Jan 13, 2025
16 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/d3-format branch January 13, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JhontSouth @coveralls @tracyboehrer