fix(react-toolbar): use contrasting token pairs for radio & toggle selected states #33579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We overrode the color for the selected state for the Radio & ToggleButton Toolbar variants, otherwise using all styles from ToggleButton. Overriding just the selected color value meant that the color/background token pair was not a pair with guaranteed contrast, which caused the Teams high contrast theme to fail contrast checks in that state.
In Teams high contrast:
New Behavior
After chatting with design, we decided to go with adopting the subtle variant of the ToggleButton's styles for the selected state for radio & toggle Toolbar buttons.
New colors in teams high contrast:
The other themes end up with the same hex values, so there is no visible change.
Related Issue(s)