-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-link): support Enter and Space keys interaction, if rendered as span #33587
Merged
mainframev
merged 2 commits into
microsoft:master
from
mainframev:link/support-enter-space-with-span
Jan 15, 2025
Merged
fix(react-link): support Enter and Space keys interaction, if rendered as span #33587
mainframev
merged 2 commits into
microsoft:master
from
mainframev:link/support-enter-space-with-span
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Pull request demo site: URL |
fabricteam
reviewed
Jan 8, 2025
Hotell
reviewed
Jan 9, 2025
packages/react-components/react-link/library/src/components/Link/useLinkState.ts
Outdated
Show resolved
Hide resolved
mainframev
force-pushed
the
link/support-enter-space-with-span
branch
2 times, most recently
from
January 10, 2025 17:00
335ef30
to
9da4ae9
Compare
khmakoto
reviewed
Jan 10, 2025
packages/react-components/react-link/library/src/components/Link/Link.test.tsx
Show resolved
Hide resolved
mainframev
force-pushed
the
link/support-enter-space-with-span
branch
from
January 10, 2025 19:19
9da4ae9
to
d3a911d
Compare
khmakoto
approved these changes
Jan 10, 2025
Hotell
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Currently keyboard interaction via
Enter
andSpace
is not possible, whenLink
is rendered asspan
.New Behavior
Added explicit handling of
Enter
andSpace
🧢Related Issue(s)