Adding basic version of DUMP and RESTORE commands #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
s3w3nofficial
force-pushed
the
s3w3nofficial/add-dump-and-restore-command
branch
from
f9c9838 to
2954d6e
Compare
badrishc
reviewed
Jan 6, 2025
| /// <summary> | ||
| /// Utils for working with redis length encoding | ||
| /// </summary> | ||
| public static class RedisLengthEncodingUtils |
There was a problem hiding this comment.
Rename redis -> resp, e.g., RespLengthEncodingUtils to clarify that this is related to the RESP protocol.
since you only ported the pycrc generated version, it seems we should be okay as it is ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only work's on string type and does not support compression, but it's still a solid starting point.
Implemented
Not Implemented
Also about the copyright for the crc64, i only ported the pycrc generated version, but still i'm not sure if and which copyright should i add.