Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report generation when multiple datasets are involved #221

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mariamedp
Copy link
Member

@mariamedp mariamedp commented Dec 12, 2024

  • Fixed name in report generation files, was causing the reports to be overriden instead of creating one for each eval flow executed.
  • Added small refactoring to reduce code duplications.

After the change, files for all eval flows executed are created. Eval flow name is used now in the file name.
Example with web classification use case:
image

combined_metrics_df.to_csv(
f"{report_dir}/{run_dataset.name}_metrics.csv"
)
fname_base = f"{report_dir}/{evaluator.name}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix. evaluator.name is used for the file name instead of run_dataset.name.

This is because run_dataset is only a temporary variable that is used in a loop some lines above to iterate through all existing datasets. Hence, run_dataset here always has the same value since it's after the loop has run and has iterated through the whole list.

@mariamedp mariamedp marked this pull request as ready for review December 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant