Skip to content

Commit

Permalink
Fix stderror check
Browse files Browse the repository at this point in the history
  • Loading branch information
AlonsoGuevara committed Jan 24, 2025
1 parent d44b459 commit c6d491c
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions tests/smoke/test_fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -288,13 +288,6 @@ def test_fixture(
result = self.__run_query(root, query)
print(f"Query: {query}\nResponse: {result.stdout}")

# Check stderr because lancedb logs path creating as WARN which leads to false negatives
stderror = (
result.stderr if "No existing dataset at" not in result.stderr else ""
)

assert stderror == "" or stderror.replace("\n", "") in KNOWN_WARNINGS, (
f"Query failed with error: {stderror}"
)
assert result.returncode == 0, "Query failed"
assert result.stdout is not None, "Query returned no output"
assert len(result.stdout) > 0, "Query returned empty output"

0 comments on commit c6d491c

Please sign in to comment.