Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new kernels #23220

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add new kernels #23220

wants to merge 6 commits into from

Conversation

bili2002
Copy link
Contributor

Description

This PR adds the kernels for int8_t, int16_t, and unsigned int inputs for Mul, Div, Add, Sub, Greater, Less, Equal, LessOrEqual, and GreaterOrEqual. The new kernels have been added for all versions of these operators that are supported by the ONNX standard.

Motivation and Context

Similarly to #15358, this change eliminates the need for intermediate type casting for these data types.

@bili2002 bili2002 marked this pull request as ready for review January 8, 2025 06:44
@snnn
Copy link
Member

snnn commented Jan 8, 2025

/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline

@snnn
Copy link
Member

snnn commented Jan 8, 2025

/azp run Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows ARM64 QNN CI Pipeline, Windows CPU CI Pipeline, Windows GPU CUDA CI Pipeline

@snnn
Copy link
Member

snnn commented Jan 8, 2025

/azp run Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@@ -183,6 +183,22 @@ TEST(MathOpTest, DimWithZeroHandling) {
run(test5);
}

TEST(MathOpTest, Add_int8) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are good. But, they are for C++ only. Would you please also add tests to ONNX so that a broader community will be benefited?

Like this:
https://github.com/onnx/onnx/blob/main/onnx/backend/test/case/node/mul.py#L35

Our pipelines run all ONNX node tests

@snnn
Copy link
Member

snnn commented Jan 9, 2025

You may need to disable the tests for TensorRT EP and DNNL EP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants