-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(poc): add scale test using clusterloader2 #1154
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alex Castilio dos Santos <[email protected]>
Signed-off-by: Alex Castilio dos Santos <[email protected]>
456dd7b
to
baf423f
Compare
Signed-off-by: Alex Castilio dos Santos <[email protected]>
baf423f
to
a3c0795
Compare
"--v=2", | ||
"--report-dir=../../perf-tests/clusterloader2/report", | ||
} | ||
cl2Path := "../../perf-tests/clusterloader2/clusterloader" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likely need an additional step for downloading cl2 bins
https://github.com/cilium/cilium/blob/main/.github/workflows/scale-test-100-gce.yaml#L176
@@ -0,0 +1,54 @@ | |||
apiVersion: apps/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to reuse a kapinger deployment elsewhere?
retina/test/trafficgen/kapinger.yaml
Line 20 in f574448
name: kapinger-rolebinding |
if we have to rev the kapinger image it's getting unwieldy to track down everywhere it's used
LabelsToGetMetrics: map[string]string{}, | ||
AdditionalTelemetryProperty: map[string]string{}, | ||
LabelsToGetMetrics: map[string]string{}, | ||
AdditionalTelemetryProperty: map[string]string{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything that was removed becomes a part of the cl2 config yeah?
# TODO: fix env vars | ||
run: | | ||
echo "RESOURCE_GROUP=lx-retina-e2e-tests" >> $GITHUB_ENV | ||
echo "LOCATION=westus2" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcoding locations has been problematic in the past, especially when we reach quota
Description
Please provide a brief description of the changes made in this pull request.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.