handle null ref exceptions in managed parser #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanrenmsft
changed the title
Charles-Gagnon
approved these changes
Jul 27, 2022
| @@ -229,7 +229,7 @@ private static List<int> GetOffsets(string content, IList<BatchInfo> batchInfos) | |||
| } | |||
|
|
|||
| // get number of characters in the last line | |||
| int endColumn = prevLine.ToCharArray().Length; | |||
| int endColumn = prevLine == null ? 0 : prevLine.ToCharArray().Length; | |||
There was a problem hiding this comment.
Update comment explaining what the situation would be where this would be null
There was a problem hiding this comment.
updated comment
nofield
pushed a commit
that referenced
this pull request
Jul 28, 2022
* handle null ref exceptions * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: microsoft/azuredatastudio#20119
The root cause of the issue is #1605, I am not familiar with this area to fix the root cause, so I opened an issue for it.
but meanwhile, we can unblock the user by properly handle the null reference exception.