Enable IsLedger only for SQL 2022 #1804
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out SMO queries fail for non-supported properties that do not apply for SQL Server versions we are connecting to, as in case of
IsLedger
for Database list, we are getting below error for SQL Server 19 and below:This PR fixes that by enabling 'IsLedger' only for SQL 2022 instead of 'AllOnPrem' - I probably didn't realize it applies to SQL 2022 only.. (ref: #1798 (comment))
cc @shueybubbles
Thanks @caohai for capturing this!