manifest install: Cache compiler information for change detection #362

autoantwort · 2022-02-17T16:25:10Z

Fixes microsoft/vcpkg#20549 (comment), microsoft/vcpkg#14025 and microsoft/vcpkg#29857.

The noop case now needs 110 ms instead of 2.2 seconds on my arm mac.
And from 2.0 sec to 18 ms when build as release

include/vcpkg/vcpkgpaths.h

src/vcpkg/install.cpp

ras0219-msft · 2022-02-23T20:01:31Z

A few independent thoughts:

MSBuild parity

I think we should consider changing our CMake integration to use the same algorithm as MSBuild. Currently, MSBuild considers:

Timestamp check on vcpkg.json
Timestamp check on vcpkg-configuration.json
Triplet name
Host triplet name

We should add "full vcpkg command line" to that list in both cases. My concern would be only that this will not pick up changes to overlay port contents or to the triplet files.

Locking

Right now, vcpkg generally performs a bunch of file locking in manifest mode that will cause this "lightweight" check to be globally serialized. For CMake usage this is less important since it's often called only once for the whole repo, but for more complex scenarios and other buildsystems it could be problematic.

Avoid hashing file contents

If the intent of this is to be a lightweight check, we should avoid hashing file contents altogether. Instead, I would suggest:

For every file under consideration, compare their modified timestamp to the stamp's modified timestamp.
If the timestamps disagree (a file is newer than the stamp), report a mismatch.
For every file under consideration, hash the path. This ensures deleting files will be tracked correctly. (In practice I think this is easiest by hashing the list of paths)
Read the stamp contents and compare against the paths hash. If not matching, report a mismatch.

If there's a mismatch, perform the install. Once the install completes, write the new paths hash to the stamp (which updates the timestamp).

We could potentially go even further here by instead having vcpkg actually report out the set of files considered as part of the build, a la /showIncludes/-M -MF. This would enable buildsystems to perform most of this check on their own without spawning a vcpkg process at all (very good for MSBuild!). One caveat with this would be correctly handling our "consider all files in this folder" cases.

autoantwort · 2022-03-17T16:04:34Z

My concern would be only that this will not pick up changes to overlay port contents or to the triplet files.

Yeah I think we should also check the timestamp of the triplet files and the overlay port files.

Right now, vcpkg generally performs a bunch of file locking in manifest mode that will cause this "lightweight" check to be globally serialized.

For msbuild this is a good thing if we still use the builtin msbuild change detection. If you for example have 10 projects in your solution and a vcpkg related change is detected, vcpkg runs 10 times in parallel. If the check is done after the lock, the first vcpkg instance will install the dependencies and then all the others will detect that there are no changes and will skip installation. If we would do the check before the locking, every vcpkg instance will detect a change and tries to install everything.
If we don't want to use the builtin msbuild check, we optimally need two checks. One before the file locking and one after. But imho for now it is enough to do the check after the locking.

For every file under consideration, hash the path. This ensures deleting files will be tracked correctly. (In practice I think this is easiest by hashing the list of paths)

We can simply check the modified date of the folders. The modified date of a folder is updated if a file is deleted, added or renamed.

Otherwise sounds good :)

# Conflicts: # locales/messages.json # src/vcpkg/base/hash.cpp

autoantwort · 2022-05-10T18:21:23Z

@ras0219-msft Are you happy with the new changes? :)

# Conflicts: # include/vcpkg/commands.setinstalled.h # locales/messages.en.json # locales/messages.json # src/vcpkg/commands.setinstalled.cpp # src/vcpkg/install.cpp

# Conflicts: # locales/messages.en.json # locales/messages.json

# Conflicts: # src/vcpkg/install.cpp

include/vcpkg/installedpaths.h

zig-for · 2022-07-06T07:38:31Z

It would be really neat if this were merged, this is really slowing down my builds.

# Conflicts: # include/vcpkg/commands.setinstalled.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/strings.cpp # src/vcpkg/commands.setinstalled.cpp # src/vcpkg/install.cpp

# Conflicts: # include/vcpkg/commands.setinstalled.h # locales/messages.en.json # locales/messages.json # src/vcpkg/commands.porthistory.cpp # src/vcpkg/commands.setinstalled.cpp # src/vcpkg/install.cpp

autoantwort · 2022-10-01T16:32:01Z

@BillyONeal Any news? :)

BillyONeal · 2022-10-03T11:54:28Z

I think for some reason I had in my mind that someone else specific was to review this one. Sorry, I don't have updated news for you.

autoantwort · 2022-10-03T12:17:23Z

Thank you for the update :) Maybe you can poke the person.
This change would mean a big improvement in usability for cmake users (100 times faster configure runs).

BillyONeal · 2022-10-03T12:44:31Z

Thank you for the update :) Maybe you can poke the person.

To clarify, I had in my mind that someone was supposed to look at this but that doesn't appear to be the case

autoantwort · 2023-02-01T14:27:28Z

According to https://discord.com/channels/400588936151433218/687365466422902841/1038192801491464192 it will probably not be merged and they will not look at it before march

# Conflicts: # src/vcpkg/base/json.cpp

# Conflicts: # include/vcpkg/base/messages.h # src/vcpkg/base/messages.cpp

dchansen · 2023-10-05T08:12:20Z

Any news on this PR?

autoantwort · 2023-10-08T23:32:17Z

No. There are concerns about cache invalidation. For example if you do the following with this PR:

vcpkg install --cache-compiler-information
Update your compiler
vcpkg install --cache-compiler-information # This understands that the compiler has been updated and reinstalled
export CXX=<path_to_different_compiler>
vcpkg install --cache-compiler-information # This would not do anything, since the cached compiler was not updated
Change vcpkg.json
Run vcpkg install. This would use the compiler abi from 3., but the compiler from 4. ⚡

So a solution could be to only use --cache-compiler-information to detect changes. If there are changes, rerun compiler detection and install packages. This would fix point 7.

Another solution is to cache the compiler and use it later (For example by sharing the CMakeCache.txt). This would use the compiler from point 3 in point 7.

Another more simple solution would be to only check if the vcpkg.json file was changed. The point 3 would do nothing and point 7 would work normally.

# Conflicts: # src/vcpkg/commands.build.cpp

BillyONeal · 2024-04-16T21:44:47Z

src/vcpkg/commands.build.cpp

@@ -666,14 +783,60 @@ namespace vcpkg
                                           const PreBuildInfo& pre_build_info,
                                           const Toolset& toolset)
    {
+        static constexpr auto vcpkg_json = R"--(


Now that we have microsoft/vcpkg#36398 do you mind if I replace this attempt to move detect_compiler out with just using what @data-queue added?

You can do it :)

include/vcpkg/installedpaths.h

BillyONeal · 2024-04-16T22:57:13Z

@BillyONeal

I've convinced myself we should take this because changing the compiler under an installed tree is already doomed.

@ras0219-msft (paraphrased)

The thing I am concerned about is corrupting binary caches. If the installed tree is toast you can recover by deleting it and reinstalling, but if binary caches are toast recovering is difficult.

If the meat of this is saying the hash algorithm is too slow, we don't need to skip the cmake detection to cache the hash. We can have a database file saying "this path was this filesize / last mod time / sha".

We could also hash the first MB of the compiler or something like that.

@BillyONeal

OK, that makes sense to me. What if we kept the compiler from the metadata cache and used that to lock the version?

@ras0219-msft (paraphrased)

That would resolve my concerns.

PatrickKa · 2024-08-02T07:43:28Z

Any update/news on this?

BillyONeal · 2024-09-25T22:20:55Z

Any update/news on this?

Given that the discussion in #362 (comment) isn't resolved I don't see progress happening here.

I did some more testing and it looks like the majority of the time is not SHA1-ing the compiler binaries, but is instead CMake detecting which compiler to use. Note that I intentionally used clang in this example, which is a 116MB binary, rather than cl.exe which is like 3MB:

PS D:\vcpkg> Measure-Command { cmake.exe -DCURRENT_PORT_DIR=D:\vcpkg\scripts\detect_compiler -DCURRENT_BUILDTREES_DIR=D:\vcpkg\buildtrees -DCURRENT_PACKAGES_DIR=D:\vcpkg\packages\detect_compiler_x64-windows -D_HOST_TRIPLET=x64-windows -DCMD=BUILD -DDOWNLOADS=D:\vcpkg-downloads -DTARGET_TRIPLET=x64-windows -DTARGET_TRIPLET_FILE=D:\vcpkg\triplets\x64-windows.cmake -DVCPKG_ROOT_DIR=D:\vcpkg -DPACKAGES_DIR=D:\vcpkg\packages -DBUILDTREES_DIR=D:\vcpkg\buildtrees -D_VCPKG_INSTALLED_DIR=D:\vcpkg\installed -DVCPKG_MANIFEST_INSTALL=OFF -DVCPKG_BASE_VERSION=2999-12-12 -DDO_HASH=OFF -P .\scripts\ports.cmake }
[1/1] "C:/Program Files/CMake/bin/cmake.exe" -E chdir ".." "C:/Program Files/CMake/bin/cmake.exe" "D:/vcpkg/scripts/detect_compiler" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=D:\vcpkg\packages\detect_compiler_x64-windows" "-DDO_HASH=OFF" "-DCMAKE_MAKE_PROGRAM=D:/vcpkg-downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=D:/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=D:/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=D:\vcpkg" "-DZ_VCPKG_ROOT_DIR=D:\vcpkg" "-D_VCPKG_INSTALLED_DIR=D:\vcpkg\installed" "-DVCPKG_MANIFEST_INSTALL=OFF"
-- The C compiler identification is Clang 18.1.6 with GNU-like command-line
-- The CXX compiler identification is Clang 18.1.6 with GNU-like command-line
#COMPILER_HASH#
#COMPILER_C_HASH#
#COMPILER_C_VERSION#18.1.6
#COMPILER_C_ID#Clang
#COMPILER_C_PATH#C:/Program Files/LLVM/bin/clang.exe
#COMPILER_CXX_HASH#
#COMPILER_CXX_VERSION#18.1.6
#COMPILER_CXX_ID#Clang
#COMPILER_CXX_PATH#C:/Program Files/LLVM/bin/clang++.exe
-- Configuring done (1.2s)
-- Generating done (0.0s)
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_SHARED_LIBS
    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_LIBDIR
    _VCPKG_ROOT_DIR


-- Build files have been written to: D:/vcpkg/buildtrees/x64-windows-rel


Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 1
Milliseconds      : 332
Ticks             : 13323311
TotalDays         : 1.54204988425926E-05
TotalHours        : 0.000370091972222222
TotalMinutes      : 0.0222055183333333
TotalSeconds      : 1.3323311
TotalMilliseconds : 1332.3311

PS D:\vcpkg> Measure-Command { cmake.exe -DCURRENT_PORT_DIR=D:\vcpkg\scripts\detect_compiler -DCURRENT_BUILDTREES_DIR=D:\vcpkg\buildtrees -DCURRENT_PACKAGES_DIR=D:\vcpkg\packages\detect_compiler_x64-windows -D_HOST_TRIPLET=x64-windows -DCMD=BUILD -DDOWNLOADS=D:\vcpkg-downloads -DTARGET_TRIPLET=x64-windows -DTARGET_TRIPLET_FILE=D:\vcpkg\triplets\x64-windows.cmake -DVCPKG_ROOT_DIR=D:\vcpkg -DPACKAGES_DIR=D:\vcpkg\packages -DBUILDTREES_DIR=D:\vcpkg\buildtrees -D_VCPKG_INSTALLED_DIR=D:\vcpkg\installed -DVCPKG_MANIFEST_INSTALL=OFF -DVCPKG_BASE_VERSION=2999-12-12 -DDO_HASH=ON -P .\scripts\ports.cmake }
[1/1] "C:/Program Files/CMake/bin/cmake.exe" -E chdir ".." "C:/Program Files/CMake/bin/cmake.exe" "D:/vcpkg/scripts/detect_compiler" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=D:\vcpkg\packages\detect_compiler_x64-windows" "-DDO_HASH=ON" "-DCMAKE_MAKE_PROGRAM=D:/vcpkg-downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=D:/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=D:/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=D:\vcpkg" "-DZ_VCPKG_ROOT_DIR=D:\vcpkg" "-D_VCPKG_INSTALLED_DIR=D:\vcpkg\installed" "-DVCPKG_MANIFEST_INSTALL=OFF"
-- The C compiler identification is Clang 18.1.6 with GNU-like command-line
-- The CXX compiler identification is Clang 18.1.6 with GNU-like command-line
#COMPILER_HASH#0f4a11f3a8b3c6eee0390888b2ca585daca373eb
#COMPILER_C_HASH#cf5d8e7225d21ffe029bdf032edaaf8a66ea0594
#COMPILER_C_VERSION#18.1.6
#COMPILER_C_ID#Clang
#COMPILER_C_PATH#C:/Program Files/LLVM/bin/clang.exe
#COMPILER_CXX_HASH#cf5d8e7225d21ffe029bdf032edaaf8a66ea0594
#COMPILER_CXX_VERSION#18.1.6
#COMPILER_CXX_ID#Clang
#COMPILER_CXX_PATH#C:/Program Files/LLVM/bin/clang++.exe
-- Configuring done (1.6s)
-- Generating done (0.0s)
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_SHARED_LIBS
    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_LIBDIR
    _VCPKG_ROOT_DIR


-- Build files have been written to: D:/vcpkg/buildtrees/x64-windows-rel


Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 1
Milliseconds      : 753
Ticks             : 17538336
TotalDays         : 2.0299E-05
TotalHours        : 0.000487176
TotalMinutes      : 0.02923056
TotalSeconds      : 1.7538336
TotalMilliseconds : 1753.8336

PS D:\vcpkg>

So the hashing is approximately (1.33-1.75)/1.33 ~= -31% of the time. Not nothing, but not the earthshattering difference in the original PR description.

Given that @ras0219-msft does not want to accept any change that skips the CMake compiler detection over the potential to damage binary caches, I am unsure what changes could be made to get this PR into a state we could merge.

BillyONeal · 2024-09-25T22:29:22Z

To clarify, the problematic scenario is:

Run vcpkg with this setting turned on.
Change something about the environment that causes a different compiler to be selected.
Run vcpkg with this setting turned on again. It sees that the compiler that was detected before has not changed, so it skips running the compiler detection step and uses the old compiler's SHAs.
Binary caching uploads bits built with a different compiler as if they were built with the old compiler.
Future binary cache hits with the old compiler are now poisoned by the new compiler.

so we would have to have high confidence that anything that could possibly change which compiler CMake could pick invalidated this detection, and it seems unlikely to me that we will ever reach that level of confidence given how lots of how CMake does this is a black box.

autoantwort · 2024-09-25T22:53:56Z

So the hashing is approximately (1.33-1.75)/1.33 ~= -31% of the time. Not nothing, but not the earthshattering difference in the original PR description.
I have tested it on my mac:
Baseline noop: 1.4s
Baseline noop without hashing: 0.5s
This PR noop: ~0.1s

Given that @ras0219-msft does not want to accept any change that skips the CMake compiler detection over the potential to damage binary caches, I am unsure what changes could be made to get this PR into a state we could merge.

I already sketched a solution but got no real response. If this is the only thing blocking this PR I will start implementing that :)

BillyONeal · 2024-09-25T23:37:49Z

I already sketched a solution but got no real response.

Sorry I missed that, can you point specifically?

autoantwort · 2024-09-25T23:47:48Z

#362 (comment)
Especially:

So a solution could be to only use --cache-compiler-information to detect changes. If there are changes, rerun compiler detection and install packages. This would fix point 7.

BillyONeal · 2024-09-26T00:49:31Z

#362 (comment) Especially:

So a solution could be to only use --cache-compiler-information to detect changes. If there are changes, rerun compiler detection and install packages. This would fix point 7.

I'm not sure how such changes are going to be possible in a way that truly sells that it's safe.

BillyONeal · 2024-09-26T00:50:24Z

If the meat of this is saying the hash algorithm is too slow, we don't need to skip the cmake detection to cache the hash. We can have a database file saying "this path was this filesize / last mod time / sha".

Would you be willing to do just this part? It would fix your Mac test and is clearly less controversial..

# Conflicts: # include/vcpkg/commands.build.h # include/vcpkg/installedpaths.h # src/vcpkg/commands.build.cpp

…fo values when building a port

autoantwort · 2025-01-02T20:38:36Z

src/vcpkg/commands.set-installed.cpp

+        if (used_cached_compiler_info)
+        {
+            if (!is_action_plan_fulfilled(action_plan, status_db))
+            {
+                // we have to install something, so get fresh compiler infos
+                for (auto& install_action : action_plan.install_actions)
+                {
+                    install_action.abi_info.clear();
+                }
+                compute_all_abis(paths, action_plan, cmake_vars, {});
+                used_cached_compiler_info = false;
+            }
+        }
        adjust_action_plan_to_status_db(action_plan, status_db);
+        if (used_cached_compiler_info)
+        {
+            Checks::check_exit(VCPKG_LINE_INFO, action_plan.empty());
+        }


Now the cached compiler info is only used to detect if there is something to install, if something gets installed, fresh compiler info are used.
(if you update your compiler the cache is not used)

autoantwort force-pushed the check-stamp branch from f982f12 to 372a6f7 Compare February 18, 2022 22:02

manifest install: Add option to check stamp file

aac20fc

autoantwort force-pushed the check-stamp branch from 372a6f7 to aac20fc Compare February 18, 2022 22:09

strega-nil-ms reviewed Feb 22, 2022

View reviewed changes

include/vcpkg/vcpkgpaths.h Outdated Show resolved Hide resolved

src/vcpkg/install.cpp Outdated Show resolved Hide resolved

src/vcpkg/install.cpp Outdated Show resolved Hide resolved

strega-nil-ms added the requires:author-response label Feb 23, 2022

strega-nil-ms reviewed Feb 23, 2022

View reviewed changes

src/vcpkg/install.cpp Outdated Show resolved Hide resolved

autoantwort added 5 commits April 24, 2022 23:20

Merge branch 'main' into check-stamp

9139104

# Conflicts: # locales/messages.json # src/vcpkg/base/hash.cpp

Check last_write_times instead of file hashes

5db2fb8

Non apple unix

35bff02

Fix warning

944317d

Format

ee3d870

autoantwort mentioned this pull request May 4, 2022

[VCPKG] vcpkg manifest adds a long delay to builds even when nothing changes microsoft/vcpkg#14025

Open

ras0219-msft self-requested a review May 10, 2022 19:58

autoantwort added 3 commits June 2, 2022 04:29

Merge branch 'main' into check-stamp

1848311

# Conflicts: # include/vcpkg/commands.setinstalled.h # locales/messages.en.json # locales/messages.json # src/vcpkg/commands.setinstalled.cpp # src/vcpkg/install.cpp

Merge branch 'main' into check-stamp

d42a431

# Conflicts: # locales/messages.en.json # locales/messages.json

Merge branch 'main' into check-stamp

bec26c8

# Conflicts: # src/vcpkg/install.cpp

BillyONeal reviewed Jun 16, 2022

View reviewed changes

include/vcpkg/installedpaths.h Outdated Show resolved Hide resolved

BillyONeal removed the requires:author-response label Jul 1, 2022

autoantwort added 4 commits August 9, 2022 17:49

Merge branch 'main' into check-stamp

21decee

# Conflicts: # include/vcpkg/commands.setinstalled.h # locales/messages.en.json # locales/messages.json # src/vcpkg/base/strings.cpp # src/vcpkg/commands.setinstalled.cpp # src/vcpkg/install.cpp

Trigger Build

d6321f4

Merge branch 'main' into check-stamp

446fc4f

Merge branch 'main' into check-stamp

0fe5b17

# Conflicts: # include/vcpkg/commands.setinstalled.h # locales/messages.en.json # locales/messages.json # src/vcpkg/commands.porthistory.cpp # src/vcpkg/commands.setinstalled.cpp # src/vcpkg/install.cpp

ras0219-msft self-assigned this Feb 1, 2023

Merge branch 'main' into check-stamp

2571fea

# Conflicts: # src/vcpkg/base/json.cpp

Neumann-A mentioned this pull request Feb 25, 2023

Improve performance of vcpkg-tool install microsoft/vcpkg#29857

Closed

autoantwort added 2 commits March 7, 2023 16:25

Merge branch 'main' into check-stamp

84a45f5

Merge branch 'main' into check-stamp

5933fcd

# Conflicts: # include/vcpkg/base/messages.h # src/vcpkg/base/messages.cpp

autoantwort added 2 commits October 12, 2023 18:23

Merge branch 'main' into check-stamp

56e7755

Merge branch 'main' into check-stamp

5ccabbc

autoantwort mentioned this pull request Oct 17, 2023

Rework and parallelize abi hashing #1225

Draft

autoantwort changed the title ~~manifest install: Cache compiler information~~ manifest install: Cache compiler information for change detection Oct 17, 2023

Merge branch 'main' into check-stamp

d39e4d7

# Conflicts: # src/vcpkg/commands.build.cpp

BillyONeal reviewed Apr 16, 2024

View reviewed changes

include/vcpkg/installedpaths.h Show resolved Hide resolved

Merge branch 'main' into check-stamp

0df3ea5

# Conflicts: # include/vcpkg/commands.build.h # include/vcpkg/installedpaths.h # src/vcpkg/commands.build.cpp

This was referenced Dec 29, 2024

Feature/cache compiler hash #1557

Closed

Compiler detection: Cache compiler hash microsoft/vcpkg#42994

Merged

Only use the cache for change detection. Never use cached compiler in…

6c940e5

…fo values when building a port

autoantwort commented Jan 2, 2025

View reviewed changes

Merge branch 'main' into check-stamp

371e0f0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

manifest install: Cache compiler information for change detection #362

manifest install: Cache compiler information for change detection #362

autoantwort commented Feb 17, 2022 •

edited

Loading

ras0219-msft commented Feb 23, 2022 •

edited

Loading

autoantwort commented Mar 17, 2022

autoantwort commented May 10, 2022

zig-for commented Jul 6, 2022

autoantwort commented Oct 1, 2022

BillyONeal commented Oct 3, 2022

autoantwort commented Oct 3, 2022

BillyONeal commented Oct 3, 2022

autoantwort commented Feb 1, 2023

dchansen commented Oct 5, 2023

autoantwort commented Oct 8, 2023 •

edited

Loading

BillyONeal Apr 16, 2024

autoantwort Apr 16, 2024

BillyONeal commented Apr 16, 2024

PatrickKa commented Aug 2, 2024

BillyONeal commented Sep 25, 2024 •

edited

Loading

BillyONeal commented Sep 25, 2024

autoantwort commented Sep 25, 2024 •

edited

Loading

BillyONeal commented Sep 25, 2024

autoantwort commented Sep 25, 2024

BillyONeal commented Sep 26, 2024

BillyONeal commented Sep 26, 2024

autoantwort Jan 2, 2025

manifest install: Cache compiler information for change detection #362

Are you sure you want to change the base?

manifest install: Cache compiler information for change detection #362

Conversation

autoantwort commented Feb 17, 2022 • edited Loading

ras0219-msft commented Feb 23, 2022 • edited Loading

MSBuild parity

Locking

Avoid hashing file contents

autoantwort commented Mar 17, 2022

autoantwort commented May 10, 2022

zig-for commented Jul 6, 2022

autoantwort commented Oct 1, 2022

BillyONeal commented Oct 3, 2022

autoantwort commented Oct 3, 2022

BillyONeal commented Oct 3, 2022

autoantwort commented Feb 1, 2023

dchansen commented Oct 5, 2023

autoantwort commented Oct 8, 2023 • edited Loading

BillyONeal Apr 16, 2024

Choose a reason for hiding this comment

autoantwort Apr 16, 2024

Choose a reason for hiding this comment

BillyONeal commented Apr 16, 2024

PatrickKa commented Aug 2, 2024

BillyONeal commented Sep 25, 2024 • edited Loading

BillyONeal commented Sep 25, 2024

autoantwort commented Sep 25, 2024 • edited Loading

BillyONeal commented Sep 25, 2024

autoantwort commented Sep 25, 2024

BillyONeal commented Sep 26, 2024

BillyONeal commented Sep 26, 2024

autoantwort Jan 2, 2025

Choose a reason for hiding this comment

autoantwort commented Feb 17, 2022 •

edited

Loading

ras0219-msft commented Feb 23, 2022 •

edited

Loading

autoantwort commented Oct 8, 2023 •

edited

Loading

BillyONeal commented Sep 25, 2024 •

edited

Loading

autoantwort commented Sep 25, 2024 •

edited

Loading