Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js and npm versions in build #78

Merged
merged 1 commit into from
Nov 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ on:
workflow_dispatch:

env:
NODE_VERSION: 16.14.2
NPM_VERSION: 8.15.1
NODE_VERSION: 18.15.0
NPM_VERSION: 9.5.0
IS_CI: 1

jobs:
Expand All @@ -29,7 +29,7 @@ jobs:
node-version: ${{env.NODE_VERSION}}

- run: npm i -g npm@${{env.NPM_VERSION}}
name: npm install npm@8.15.1
name: npm install npm@9.5.0

- run: npm install
name: npm install
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
node-version: ${{env.NODE_VERSION}}

- run: npm i -g npm@${{env.NPM_VERSION}}
name: npm install npm@8.15.1
name: npm install npm@9.5.0

- run: npm install
name: npm install
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.14.2
v18.15.0
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ Before starting on a PR an [issue](https://github.com/microsoft/vscode-jupyter-p
Submissions that do not have an associated issue are unlikely to be approved.

### Prerequisites
1. [Node.js](https://nodejs.org/) 16.14.2
2. [npm](https://www.npmjs.com/) 8.15.1
1. [Node.js](https://nodejs.org/) 18.15.0
2. [npm](https://www.npmjs.com/) 9.5.0
3. [Visual Studio Code](https://code.visualstudio.com/)

### Setup
Expand Down
4 changes: 2 additions & 2 deletions azure-pipeline.stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ extends:
parameters:
publishExtension: ${{ parameters.publishExtension }}
buildSteps:
- script: npm i -g npm@8.15.1
displayName: npm install npm@8.15.1
- script: npm i -g npm@9.5.0
displayName: npm install npm@9.5.0

- script: npm ci
displayName: Install dependencies
Expand Down
Loading