Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waitUntil for onDidStart event #16375

Merged
merged 19 commits into from
Jan 20, 2025
Merged

Conversation

pwang347
Copy link
Member

@pwang347 pwang347 commented Jan 13, 2025

For more context, see #16387

@pwang347 pwang347 changed the title [DRAFT] Add waitUntil for onDidStart event Add waitUntil for onDidStart event Jan 15, 2025
@pwang347 pwang347 marked this pull request as ready for review January 15, 2025 22:54
Copy link
Contributor

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes, else all looks good.

src/kernels/kernel.ts Outdated Show resolved Hide resolved
src/kernels/kernel.ts Outdated Show resolved Hide resolved
src/kernels/kernel.ts Outdated Show resolved Hide resolved
src/kernels/kernelExecution.ts Outdated Show resolved Hide resolved
src/kernels/types.ts Outdated Show resolved Hide resolved
src/standalone/api/kernels/api.vscode.common.test.ts Outdated Show resolved Hide resolved
src/standalone/api/kernels/api.vscode.common.test.ts Outdated Show resolved Hide resolved
src/standalone/api/kernels/index.ts Show resolved Hide resolved
DonJayamanne
DonJayamanne previously approved these changes Jan 20, 2025
@DonJayamanne DonJayamanne enabled auto-merge (squash) January 20, 2025 00:54
@DonJayamanne DonJayamanne disabled auto-merge January 20, 2025 00:54
@DonJayamanne DonJayamanne enabled auto-merge (squash) January 20, 2025 00:55
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Jan 20, 2025
@DonJayamanne DonJayamanne disabled auto-merge January 20, 2025 00:58
@DonJayamanne DonJayamanne enabled auto-merge (squash) January 20, 2025 01:12
@DonJayamanne DonJayamanne merged commit 5fe5bb5 into microsoft:main Jan 20, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants