Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose shell's environment - zsh #237977

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Expose shell's environment - zsh #237977

wants to merge 16 commits into from

Conversation

anthonykim1
Copy link
Contributor

Trying to break #228791 down smaller so that it is easier to review.

Part of #227467

@anthonykim1 anthonykim1 self-assigned this Jan 15, 2025
@anthonykim1 anthonykim1 added this to the January 2025 milestone Jan 15, 2025
@anthonykim1 anthonykim1 requested a review from Tyriar January 16, 2025 14:51
@anthonykim1
Copy link
Contributor Author

Going through more rigorous testing, I realized sometimes (although very not expected), things like -q show up as an environment variable's value. This of course throws error. I've aimed to better handle it now, soo it skips that variable entirely.

Also since hypens shouldn't really be part of variable name, we would skip the 'sending' of the variable if we detect usage of - in an environment variable name.

Screenshot 2025-01-17 at 1 14 56 AM

@anthonykim1 anthonykim1 marked this pull request as ready for review January 17, 2025 06:47
@anthonykim1 anthonykim1 requested a review from Tyriar January 17, 2025 06:47
@anthonykim1 anthonykim1 marked this pull request as draft January 17, 2025 06:47
@anthonykim1 anthonykim1 marked this pull request as ready for review January 17, 2025 06:49
@anthonykim1 anthonykim1 requested a review from Tyriar January 21, 2025 22:35
@Tyriar
Copy link
Member

Tyriar commented Jan 22, 2025

@anthonykim1 could you test performance with and without this to see what sort of overhead it adds?

@anthonykim1
Copy link
Contributor Author

anthonykim1 commented Jan 22, 2025

@Tyriar It might be better if I do it in #238488 first with bash since I've already got started with it. I think I narrowed it down so it is as instant as before. Will still do the timing test to see how much time it is adding too!

Will move this to draft until I resolve bash perf, and also fix zsh perf (they pretty much share perf-issue logic so higher probability that some changes are needed here on zsh script as well)

@anthonykim1 anthonykim1 marked this pull request as draft January 22, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants