-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose shell's environment - zsh #237977
base: main
Are you sure you want to change the base?
Expose shell's environment - zsh #237977
Conversation
extensions/vscode-api-tests/src/singlefolder-tests/terminal.shellIntegration.test.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-rc.zsh
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-rc.zsh
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-rc.zsh
Outdated
Show resolved
Hide resolved
@anthonykim1 could you test performance with and without this to see what sort of overhead it adds? |
@Tyriar It might be better if I do it in #238488 first with bash since I've already got started with it. I think I narrowed it down so it is as instant as before. Will still do the timing test to see how much time it is adding too! Will move this to draft until I resolve bash perf, and also fix zsh perf (they pretty much share perf-issue logic so higher probability that some changes are needed here on zsh script as well) |
Trying to break #228791 down smaller so that it is easier to review.
Part of #227467