Skip to content

Commit

Permalink
Merge commit '9060ee1c8c16dc6d5746152a3f737d69762da99e' into release
Browse files Browse the repository at this point in the history
  • Loading branch information
github-actions[bot] committed Apr 2, 2022
2 parents 45a609b + 9060ee1 commit c54bd1f
Show file tree
Hide file tree
Showing 6 changed files with 56 additions and 3 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

## [Unreleased]

## [0.11.5] - 2022-04-02

- Adds support for route-manifest v4 ([#292](https://github.com/milliHQ/terraform-aws-next-js/pull/292))
This ensures the builder works with Next.js versions `>= v12.1.3`.
- Restrict [image optimizer](https://github.com/milliHQ/terraform-aws-next-js-image-optimization) submodule version to `<= v12.0.10` ([#293](https://github.com/milliHQ/terraform-aws-next-js/pull/293))
Since the `v12.0.10` release is the last version with support for [Terraform AWS Provider](https://registry.terraform.io/providers/hashicorp/aws/) `v3.x` this update ensures existing setups will not break in the future.
- Bump @vercel/build-utils from `2.10.1` to `2.12.1` ([#287](https://github.com/milliHQ/terraform-aws-next-js/pull/287))

## [0.11.4] - 2022-02-01

### Fixed
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,8 @@ So issues that exist on Vercel are likely to occur on this project too.

You should be able to run`terraform apply` again and the stack creation would progreed without this error.

- [Function decreases account's UnreservedConcurrentExecution below its minimum value](https://github.com/milliHQ/terraform-aws-next-js/tree/main/docs/known-issues/0001_reserved-concurrent-executions.md)

## Contributing

Contributions are welcome!
Expand Down
43 changes: 43 additions & 0 deletions docs/known-issues/0001_reserved-concurrent-executions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# Function decreases account's UnreservedConcurrentExecution below its minimum value

<table>
<tr>
<th>Status</th>
<td>workaround available</td>
</tr>
<tr>
<th>x-ref</th>
<td>
<a href="https://github.com/milliHQ/terraform-aws-next-js/issues/251">#251</a>
</td>
</tr>
</table>

## Error message

After running the initial `terraform apply`, the command fails with the following error message:

> Specified ReservedConcurrentExecutions for function decreases account's UnreservedConcurrentExecution below its minimum value of [50].
## Problem

The module requests a reserved concurrent execution of 1 for the deploy-trigger component.
This is a Lambda function that runs after every apply and is responsible for updating files in the associated S3 bucket.

To ensure that concurrent deployments do not override each other, we limit the maximal number of concurrent instances of this function to 1.

While this produces no extra costs, it counts towards the account's concurrent executions quota.

For newer AWS accounts this quota has been lowered from 1000 to 50.

Since 50 is the account's required minimum for concurrent executions, no new lambda with a reserved concurrent execution can be created.

## Workaround

You can simply request an increase of the "Concurrent executions quota" (L-B99A9384) through the AWS console at no extra costs.

The quota increase can be requested here: https://console.aws.amazon.com/servicequotas/home/services/lambda/quotas/L-B99A9384

Any value greater than 50 should work, the [default quota is 1000](https://docs.aws.amazon.com/lambda/latest/dg/gettingstarted-limits.html#compute-and-storage).

It usually takes 2-3 business days until the increase is granted.
2 changes: 1 addition & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ module "next_image" {
count = var.create_image_optimization ? 1 : 0

source = "milliHQ/next-js-image-optimization/aws"
version = ">= 11.0.0"
version = "~> 12.0.10"

cloudfront_create_distribution = false

Expand Down
2 changes: 1 addition & 1 deletion modules/proxy/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

variable "proxy_module_version" {
type = string
default = "0.11.4"
default = "0.11.5"
}

variable "lambda_default_runtime" {
Expand Down
2 changes: 1 addition & 1 deletion modules/statics-deploy/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ variable "static_files_archive" {

variable "deploy_trigger_module_version" {
type = string
default = "0.11.4"
default = "0.11.5"
}

variable "expire_static_assets" {
Expand Down

0 comments on commit c54bd1f

Please sign in to comment.