Remove short flag from history purge command.
#5242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command `minder history purge` supports specifying a custom batch size via `--batch-size/-s` option. The short version `-s` overlaps with the short version of `--db-sslmode`, which is a root-level option. This change solves the overlap by removing the short option from `minder history purge`.
eleftherias
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The command
minder history purgesupports specifying a custom batch size via--batch-size/-soption. The short version-soverlaps with the short version of--db-sslmode, which is a root-level option.This change solves the overlap by removing the short option from
minder history purge.Change Type
Mark the type of change your PR introduces:
Testing
Manual tests.
Review Checklist: