Bump devise_saml_authenticatable from 1.5.0 to 1.6.1 to 1.6.2 #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
|
See my comments on the previous update for this dependancy: #1584 |
dependabot-preview
bot
force-pushed
the
dependabot/bundler/devise_saml_authenticatable-1.6.1
branch
2 times, most recently
from
c49ee64 to
434afd3
Compare
Bumps [devise_saml_authenticatable]() from 1.5.0 to 1.6.1. Signed-off-by: dependabot-preview[bot] <[email protected]>
stephenrichards
force-pushed
the
dependabot/bundler/devise_saml_authenticatable-1.6.1
branch
from
434afd3 to
47c6d26
Compare
|
A newer version of devise_saml_authenticatable exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
colinbruce
approved these changes
Sep 29, 2020
colinbruce
reviewed
Sep 29, 2020
Gemfile.lock
Outdated
| @@ -181,7 +181,7 @@ GEM | |||
| railties (>= 4.1.0) | |||
| responders | |||
| warden (~> 1.2.3) | |||
| devise_saml_authenticatable (1.5.0) | |||
| devise_saml_authenticatable (1.6.1) | |||
There was a problem hiding this comment.
Actually, it might be worth bumping this to 1.6.2 - it's a reversion for a bug introduced in 1.6.1
stephenrichards
changed the title
stephenrichards
deleted the
dependabot/bundler/devise_saml_authenticatable-1.6.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
After discussion with developer, he agreed that the update did not handle instances like ours where the user model was named anything other than user. To get over this, I created a method
#current_useron theSamlSessionsControllerwhich returns the current provider.Also, disabled the devise
session_index_keyconfiguration setting, as it now expects to find a method of the specified name on the Provider model.See issue raised with developer: apokalipto/devise_saml_authenticatable#183
Bumps devise_saml_authenticatable from 1.5.0 to 1.6.1.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: