Add titelbar in external view #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for window resizing and moving
neomilium
requested changes
Apr 2, 2017
| @@ -40,7 +40,7 @@ ExternalMasterView::ExternalMasterView(QWidget *parent) : | |||
|
|
|||
| ui->setupUi(this); | |||
| this->layout()->addWidget(_uiMasterMonitor); | |||
| this->setWindowFlags(this->windowFlags() | Qt::FramelessWindowHint); | |||
| this->setWindowFlags(this->windowFlags() | Qt::Window | Qt::CustomizeWindowHint | Qt::FramelessWindowHint ); //Qt::FramelessWindowHint for disable border | |||
There was a problem hiding this comment.
Comment at the end of line is useless and commented code is prohibited to keep sources clean :-)
|
Could you look at review, fix code and fix typo in commit log. Note : in Minotor, we use commit logs with format 'XXX: changes' where XXX is the affected part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for window resizing and moving, it wasn't possible before.