Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Glyphicons with Bootstrap Icons #990

Closed
wants to merge 4 commits into from

Conversation

liamkeily
Copy link
Collaborator

@liamkeily liamkeily commented Jan 16, 2024

To help with the Bootstrap 5 upgrade #973 I have taken the icon related changes from the other branch and fixed some of the issues. This seems like something we could potentially merge first to help remove distractions from the other PR.

Merge request checklist

  • I read the guidelines for contributing
  • I created my branch from dev and I am issuing the PR to dev
  • I didn't pushed the dist directory
  • If it's a new feature, I added the necessary unit tests
  • If it's a new language, I filled the __locale and __author fields

Before

image

After

image

@liamkeily liamkeily mentioned this pull request Jan 16, 2024
4 tasks
@mistic100
Copy link
Owner

I don't see the point, the BT5 support won't be merged/released until you declare the merge request ready. No point in releasing only the icons.

@liamkeily
Copy link
Collaborator Author

liamkeily commented Jan 16, 2024

Glyphicons is no longer supported by Bootstrap 5 but Bootstrap Icons appears to work regardless of Bootstrap version.

Use them with or without Bootstrap in any project.

I thought breaking this part out would help to reduce the diff of the Bootstrap 5 related stuff to help with reviewing / testing / fixing the remaining issues.

@liamkeily
Copy link
Collaborator Author

Carried this on here #992

@liamkeily liamkeily closed this Jan 17, 2024
@liamkeily liamkeily deleted the refactor/bootstrap-icons branch January 17, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants