Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional table movement experiment improvements #506

Merged
merged 3 commits into from
May 3, 2024
Merged

Conversation

geoffxy
Copy link
Member

@geoffxy geoffxy commented May 3, 2024

This is primarily for the specialized scenario.

  • Remove the embeddings table from Athena
  • Exclude it from the all tables constraint (in the VDBE abstraction, this table will have different constraints anyways, so this is natural)
  • Add a defensive data type conversion for the vector data type (unsure if unloading will even work)

Part of #487.

@geoffxy geoffxy self-assigned this May 3, 2024
@geoffxy geoffxy merged commit e297115 into main May 3, 2024
1 check passed
@geoffxy geoffxy deleted the gy-tm-fixes branch May 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant