Merge pull request #10 from mittwald/chore/more-rector-rules

Add more rector rules to remove unnecessary doccomment tags

rector.php

@@ -4,14 +4,22 @@
 
 use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
 use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\ClassMethod\RemoveUselessParamTagRector;
+use Rector\DeadCode\Rector\ClassMethod\RemoveUselessReturnTagRector;
+use Rector\DeadCode\Rector\Property\RemoveUselessVarTagRector;
 use Rector\Set\ValueObject\LevelSetList;
 use Rector\TypeDeclaration\Rector\ClassMethod\ReturnNeverTypeRector;
+use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->paths([
         __DIR__ . '/src',
     ]);
 
     $rectorConfig->rule(ReturnNeverTypeRector::class);
+    $rectorConfig->rule(DeclareStrictTypesRector::class);
+    $rectorConfig->rule(RemoveUselessVarTagRector::class);
+    $rectorConfig->rule(RemoveUselessParamTagRector::class);
+    $rectorConfig->rule(RemoveUselessReturnTagRector::class);
     $rectorConfig->importNames();
 };

src/Client/BaseClient.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mittwald\ApiClient\Client;
 
 use GuzzleHttp\Client;

src/Client/EmptyResponse.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mittwald\ApiClient\Client;
 
 use Psr\Http\Message\ResponseInterface;

src/Client/ResponseTrait.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mittwald\ApiClient\Client;
 
 use Psr\Http\Message\ResponseInterface;

src/Client/StringResponse.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mittwald\ApiClient\Client;
 
 use Psr\Http\Message\ResponseInterface;

src/Client/UntypedResponse.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mittwald\ApiClient\Client;
 
 use Psr\Http\Message\ResponseInterface;

src/Generated/V2/Client.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mittwald\ApiClient\Generated\V2;
 
 use Mittwald\ApiClient\Generated\V2\Clients\App\AppClient;

src/Generated/V2/ClientImpl.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mittwald\ApiClient\Generated\V2;
 
 use Mittwald\ApiClient\Client\BaseClient;

src/Generated/V2/Clients/App/AppClient.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mittwald\ApiClient\Generated\V2\Clients\App;
 
 use GuzzleHttp\Exception\GuzzleException;

src/Generated/V2/Clients/App/AppClientImpl.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mittwald\ApiClient\Generated\V2\Clients\App;
 
 use GuzzleHttp\Client;

src/Generated/V2/Clients/App/DeprecatedAppLinkDatabase/DeprecatedAppLinkDatabaseDefaultResponse.php

@@ -14,8 +14,6 @@ class DeprecatedAppLinkDatabaseDefaultResponse implements ResponseContainer
 {
     /**
      * Schema used to validate input for creating instances of this class
-     *
-     * @var array
      */
     private static array $schema = [
         'type' => 'object',
@@ -29,33 +27,20 @@ class DeprecatedAppLinkDatabaseDefaultResponse implements ResponseContainer
         ],
     ];
 
-    /**
-     * @var Error
-     */
     private Error $body;
 
     private ResponseInterface|null $httpResponse = null;
 
-    /**
-     * @param Error $body
-     */
     public function __construct(Error $body)
     {
         $this->body = $body;
     }
 
-    /**
-     * @return Error
-     */
     public function getBody(): Error
     {
         return $this->body;
     }
 
-    /**
-     * @param Error $body
-     * @return self
-     */
     public function withBody(Error $body): self
     {
         $clone = clone $this;

src/Generated/V2/Clients/App/DeprecatedAppLinkDatabase/DeprecatedAppLinkDatabaseNotFoundResponse.php

@@ -14,8 +14,6 @@ class DeprecatedAppLinkDatabaseNotFoundResponse implements ResponseContainer
 {
     /**
      * Schema used to validate input for creating instances of this class
-     *
-     * @var array
      */
     private static array $schema = [
         'type' => 'object',
@@ -29,33 +27,20 @@ class DeprecatedAppLinkDatabaseNotFoundResponse implements ResponseContainer
         ],
     ];
 
-    /**
-     * @var Error
-     */
     private Error $body;
 
     private ResponseInterface|null $httpResponse = null;
 
-    /**
-     * @param Error $body
-     */
     public function __construct(Error $body)
     {
         $this->body = $body;
     }
 
-    /**
-     * @return Error
-     */
     public function getBody(): Error
     {
         return $this->body;
     }
 
-    /**
-     * @param Error $body
-     * @return self
-     */
     public function withBody(Error $body): self
     {
         $clone = clone $this;

src/Generated/V2/Clients/App/DeprecatedAppLinkDatabase/DeprecatedAppLinkDatabaseRequest.php

@@ -13,8 +13,6 @@ class DeprecatedAppLinkDatabaseRequest
 
     /**
      * Schema used to validate input for creating instances of this class
-     *
-     * @var array
      */
     private static array $schema = [
         'type' => 'object',
@@ -57,50 +55,30 @@ class DeprecatedAppLinkDatabaseRequest
         ],
     ];
 
-    /**
-     * @var string
-     */
     private string $appInstallationId;
 
-    /**
-     * @var DeprecatedAppLinkDatabaseRequestBody
-     */
     private DeprecatedAppLinkDatabaseRequestBody $body;
 
     private array $headers = [
 
     ];
 
-    /**
-     * @param string $appInstallationId
-     * @param DeprecatedAppLinkDatabaseRequestBody $body
-     */
     public function __construct(string $appInstallationId, DeprecatedAppLinkDatabaseRequestBody $body)
     {
         $this->appInstallationId = $appInstallationId;
         $this->body = $body;
     }
 
-    /**
-     * @return string
-     */
     public function getAppInstallationId(): string
     {
         return $this->appInstallationId;
     }
 
-    /**
-     * @return DeprecatedAppLinkDatabaseRequestBody
-     */
     public function getBody(): DeprecatedAppLinkDatabaseRequestBody
     {
         return $this->body;
     }
 
-    /**
-     * @param string $appInstallationId
-     * @return self
-     */
     public function withAppInstallationId(string $appInstallationId): self
     {
         $validator = new Validator();
@@ -115,10 +93,6 @@ public function withAppInstallationId(string $appInstallationId): self
         return $clone;
     }
 
-    /**
-     * @param DeprecatedAppLinkDatabaseRequestBody $body
-     * @return self
-     */
     public function withBody(DeprecatedAppLinkDatabaseRequestBody $body): self
     {
         $clone = clone $this;

src/Generated/V2/Clients/App/DeprecatedAppLinkDatabase/DeprecatedAppLinkDatabaseRequestBody.php

@@ -11,8 +11,6 @@ class DeprecatedAppLinkDatabaseRequestBody
 {
     /**
      * Schema used to validate input for creating instances of this class
-     *
-     * @var array
      */
     private static array $schema = [
         'properties' => [
@@ -42,34 +40,21 @@ class DeprecatedAppLinkDatabaseRequestBody
         'type' => 'object',
     ];
 
-    /**
-     * @var string
-     */
     private string $databaseId;
 
     /**
      * @var string[]|null
      */
     private ?array $databaseUserIds = null;
 
-    /**
-     * @var DeprecatedAppLinkDatabaseRequestBodyPurpose
-     */
     private DeprecatedAppLinkDatabaseRequestBodyPurpose $purpose;
 
-    /**
-     * @param string $databaseId
-     * @param DeprecatedAppLinkDatabaseRequestBodyPurpose $purpose
-     */
     public function __construct(string $databaseId, DeprecatedAppLinkDatabaseRequestBodyPurpose $purpose)
     {
         $this->databaseId = $databaseId;
         $this->purpose = $purpose;
     }
 
-    /**
-     * @return string
-     */
     public function getDatabaseId(): string
     {
         return $this->databaseId;
@@ -83,18 +68,11 @@ public function getDatabaseUserIds(): ?array
         return $this->databaseUserIds ?? null;
     }
 
-    /**
-     * @return DeprecatedAppLinkDatabaseRequestBodyPurpose
-     */
     public function getPurpose(): DeprecatedAppLinkDatabaseRequestBodyPurpose
     {
         return $this->purpose;
     }
 
-    /**
-     * @param string $databaseId
-     * @return self
-     */
     public function withDatabaseId(string $databaseId): self
     {
         $validator = new Validator();
@@ -111,7 +89,6 @@ public function withDatabaseId(string $databaseId): self
 
     /**
      * @param string[] $databaseUserIds
-     * @return self
      */
     public function withDatabaseUserIds(array $databaseUserIds): self
     {
@@ -127,9 +104,6 @@ public function withDatabaseUserIds(array $databaseUserIds): self
         return $clone;
     }
 
-    /**
-     * @return self
-     */
     public function withoutDatabaseUserIds(): self
     {
         $clone = clone $this;
@@ -138,10 +112,6 @@ public function withoutDatabaseUserIds(): self
         return $clone;
     }
 
-    /**
-     * @param DeprecatedAppLinkDatabaseRequestBodyPurpose $purpose
-     * @return self
-     */
     public function withPurpose(DeprecatedAppLinkDatabaseRequestBodyPurpose $purpose): self
     {
         $clone = clone $this;

src/Generated/V2/Clients/App/DeprecatedAppLinkDatabase/DeprecatedAppLinkDatabaseRequestBodyPurpose.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mittwald\ApiClient\Generated\V2\Clients\App\DeprecatedAppLinkDatabase;
 
 enum DeprecatedAppLinkDatabaseRequestBodyPurpose: string

src/Generated/V2/Clients/App/ExecuteAction/ExecuteActionDefaultResponse.php

@@ -14,8 +14,6 @@ class ExecuteActionDefaultResponse implements ResponseContainer
 {
     /**
      * Schema used to validate input for creating instances of this class
-     *
-     * @var array
      */
     private static array $schema = [
         'type' => 'object',
@@ -29,33 +27,20 @@ class ExecuteActionDefaultResponse implements ResponseContainer
         ],
     ];
 
-    /**
-     * @var Error
-     */
     private Error $body;
 
     private ResponseInterface|null $httpResponse = null;
 
-    /**
-     * @param Error $body
-     */
     public function __construct(Error $body)
     {
         $this->body = $body;
     }
 
-    /**
-     * @return Error
-     */
     public function getBody(): Error
     {
         return $this->body;
     }
 
-    /**
-     * @param Error $body
-     * @return self
-     */
     public function withBody(Error $body): self
     {
         $clone = clone $this;