Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project: mkdocs-material-adr #291

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Add project: mkdocs-material-adr #291

merged 3 commits into from
Jan 16, 2025

Conversation

Kl0ven
Copy link
Contributor

@Kl0ven Kl0ven commented Jan 16, 2025

What kind of change does this PR introduce?

  • Add a project
  • Update a project
  • Remove a project
  • Add or update a category
  • Change configuration
  • Documentation
  • Other, please describe:

Description:

Add mkdocs-material-adr project

Checklist:

  • I have read the CONTRIBUTING guidelines.
  • I have not modified the README.md file. Projects are only supposed to be added or updated within the projects.yaml file since the README.md file is automatically generated.

Copy link
Collaborator

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks for the PR 🙂 Could you just move the new entry at the end of the api-docs group instead of the end of the file?

@pawamoy
Copy link
Collaborator

pawamoy commented Jan 16, 2025

I'm now wondering if api-docs is the right category 🤔 I'll merge anyway, feel free to send another PR if you want to change the category 🙂

@pawamoy pawamoy merged commit 1a81cce into mkdocs:main Jan 16, 2025
1 check passed
@Kl0ven
Copy link
Contributor Author

Kl0ven commented Jan 16, 2025

Thanks :)
Yes, api-docs is pushing it, would it be worth creating a architecture-doc ?

@pawamoy
Copy link
Collaborator

pawamoy commented Jan 16, 2025

I'd prefer not adding new categories with a single item in them. I also agree that it doesn't really fit in other categories. Maybe "integration with other tools"? As in, it integrates with ADR in general. I'm fine with keeping it in API docs for now 🤷 As you want!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants