fix: no parameters

mlr-org · Jun 20, 2024 · 1b40b7e · 1b40b7e
1 parent 00eef77
commit 1b40b7e
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 2 deletions.
diff --git a/R/OptimInstance.R b/R/OptimInstance.R
@@ -83,7 +83,7 @@ OptimInstance = R6Class("OptimInstance",
       cli_li(sprintf("Objective: %s", class(self$objective)[1]))
       cli_li("Search Space:")
       print(as.data.table(self$search_space)[, c("id", "class", "lower", "upper", "nlevels"), with = FALSE])
-      cli_li(sprintf("Terminator: %s (%s)", class(self$terminator)[1], as_short_string(self$terminator$param_set$values)))
+      cli_li(sprintf("Terminator: %s %s", class(self$terminator)[1], if (length(self$terminator$param_set$values)) paste0("(", as_short_string(self$terminator$param_set$values), ")") else ""))
       if (!is.null(private$.result)) {
         cli_li("Result:")
         print(self$result[, c(self$archive$cols_x, self$archive$cols_y), with = FALSE])

diff --git a/R/Terminator.R b/R/Terminator.R
@@ -75,7 +75,7 @@ Terminator = R6Class("Terminator",
     #' @param ... (ignored).
     print = function(...) {
       cli_h1(sprintf("%s %s", class(self)[1L], if (is.na(self$label)) "" else paste0("- ", self$label)))
-      cli_li(sprintf("Parameters: %s", if (length(self$param_set$values)) as_short_string(self$param_set$values) else "-"))
+      cli_li(sprintf("Parameters: %s", if(length(self$param_set$values)) as_short_string(self$param_set$values) else "-"))
     },
 
     #' @description

diff --git a/tests/testthat/_snaps/TerminatorNone.md b/tests/testthat/_snaps/TerminatorNone.md
@@ -0,0 +1,20 @@
+# TerminatorNone works
+
+    Code
+      terminators
+    Output
+      $evals
+    Message
+      
+      -- TerminatorEvals - Number of Evaluation --------------------------------------
+      * Parameters: n_evals=10, k=0
+    Output
+      
+      $none
+    Message
+      
+      -- TerminatorNone - None -------------------------------------------------------
+      * Parameters: -
+    Output
+      
+