limit number of cores

mlr-org · Nov 8, 2024 · 53e1df8 · 53e1df8
1 parent c2bfb6b
commit 53e1df8
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 5 deletions.
diff --git a/R/FilterBoruta.R b/R/FilterBoruta.R
@@ -10,6 +10,12 @@
 #' The order of selected features is random.
 #' In combination with \CRANpkg{mlr3pipelines}, only the filter criterion `cutoff` makes sense.
 #'
+#' @section Initial parameter values:
+#' - `num.threads`:
+#'   - Actual default: `NULL`, triggering auto-detection of the number of CPUs.
+#'   - Adjusted value: 1.
+#'   - Reason for change: Conflicting with parallelization via \CRANpkg{future}.
+#'
 #' @references
 #' `r format_bib("kursa_2010")`
 #'
@@ -43,10 +49,11 @@ FilterBoruta = R6Class("FilterBoruta",
         doTrace = p_int(lower = 0, upper = 4, default = 0),
         holdHistory = p_lgl(default = TRUE),
         getImp = p_uty(),
-        keep = p_fct(levels = c("confirmed", "tentative"), default = "confirmed")
+        keep = p_fct(levels = c("confirmed", "tentative"), default = "confirmed"),
+        num.threads = p_int(lower = 1, default = 1)
       )
 
-      param_set$set_values(keep = "confirmed")
+      param_set$set_values(keep = "confirmed", num.threads = 1)
 
       super$initialize(
         id = "boruta",

diff --git a/man/mlr3filters-package.Rd b/man/mlr3filters-package.Rd
diff --git a/man/mlr_filters_boruta.Rd b/man/mlr_filters_boruta.Rd
diff --git a/tests/testthat/test_filter_regr.R b/tests/testthat/test_filter_regr.R
@@ -35,8 +35,8 @@ test_that("filters throw errors on missing values", {
 })
 
 test_that("Errors for unsupported features", {
-  skip_if("ames_housing" %nin% mlr_tasks$keys())
-  task = tsk("ames_housing")
+  skip_if("california_housing" %nin% mlr_tasks$keys())
+  task = tsk("california_housing")
   filters = mlr_filters$mget(mlr_filters$keys())
 
   # supported: numeric, integer