fix: correct factor collapsing for ordered factors

mlr-org · Nov 5, 2024 · 2e17881 · 2e17881
1 parent 4b311b6
commit 2e17881
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/R/PipeOpCollapseFactors.R b/R/PipeOpCollapseFactors.R
@@ -114,9 +114,9 @@ PipeOpCollapseFactors = R6Class("PipeOpCollapseFactors",
             if (position == 1) {
               cmap[[2]] = c(cmap[[2]], eliminating)
             } else if (position == length(cmap) || dtable[position - 1] < dtable[position + 1]) {
-              cmap[[position - 1]] = c(cmap[[position - 1]], eliminating)
+              cmap[[position - 1]] = c(cmap[[position - 1]], cmap[[eliminating]])
             } else {
-              cmap[[position + 1]] = c(cmap[[position + 1]], eliminating)
+              cmap[[position + 1]] = c(cmap[[position + 1]], cmap[[eliminating]])
             }
             dtable = dtable[-position]
             cmap[[position]] = NULL

diff --git a/tests/testthat/test_pipeop_collapsefactors.R b/tests/testthat/test_pipeop_collapsefactors.R
@@ -19,6 +19,7 @@ test_that("PipeOpCollapseFactors", {
   #                 correct levels are chosen for this
   train_out = op$train(list(task))[[1]]
 
+  # test: ordered, correct renaming
 
   # test: prevalance works
   # test: absolute works