Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funloc dataset to test support for session-specific anat #1039

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

drammock
Copy link
Member

Per conversation with @larsoner I'm splitting out the work of adding the funloc dataset (and fixing the bugs it reveals) to make the diff cleaner on #1035 (which is actually dealing with a different problem than what funloc addresses --- #1035 is about skipping missing sessions, not handling session-specific anat).

Before merging …

  • Changelog has been updated (docs/source/dev.md.inc)

# Epochs
epochs_tmin = -0.2
epochs_tmax = 0.5
epochs_t_adjust = -4.0e-3 # TODO is there a way to do this in MBP?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsoner does MBP have a way of doing what t_adjust does in mnefun?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this should be fixed/adjusted when bidsifying the dataset I think (the timings, event types, etc. in there should be as accurate as possible and not require fixing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants