Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install stable rust toolchain #26

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

zhassan-aws
Copy link
Contributor

Description of changes:

The GitHub action currently requires updating the rust toolchain to install with every new release of Kani (as opposed to just updating the version of Kani). This shouldn't be necessary as Kani installs the required toolchain as part of its setup.

Resolved issues:

Resolves #9

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? Existing tests

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will install 2 toolchains which I don't think it's ideal, but we can optimize this later by just pulling the correct toolchain from our repository. That said, it's probably better than relying on manual update.

@zhassan-aws zhassan-aws merged commit 7857f4f into model-checking:main Feb 15, 2023
@zhassan-aws zhassan-aws deleted the use-stable branch February 15, 2023 19:43
@zhassan-aws
Copy link
Contributor Author

This will install 2 toolchains which I don't think it's ideal, but we can optimize this later by just pulling the correct toolchain from our repository.

Filed #27 for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically get the rust version from the kani toolchain.toml
2 participants