Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds i18n support #115

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

LaurentAjdnik
Copy link
Contributor

Motivation and Context

Fixes #86.

Temporary PR for further discussion. Documentation very partially updated for now.

Note : "preferredLanguage", as a string, has been turned into "preferredLanguages", as an array of strings, which is a more common practice.

How Has This Been Tested?

Not so well, I fear...

Breaking Changes

None (Only new optional fields in initialization messages).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me. I won't accept it for now as we are waiting to create the draft subdirectory for docs, but otherwise good to go in my mind. We would need to do better on the actual docs tho, describing it in more depth.

Thank you for working on this!

| Client | `experimental` | Describes support for non-standard experimental features |
| Server | `prompts` | Offers [prompt templates]({{< ref "/specification/server/prompts" >}}) |
| Server | `resources` | Provides readable [resources]({{< ref "/specification/server/resources" >}}) |
| Server | `tools` | Exposes callable [tools]({{< ref "/specification/server/tools" >}}) |
| Server | `logging` | Emits structured [log messages]({{< ref "/specification/server/utilities/logging" >}}) |
| Server | `locale` | | Provides [i18n support]({{< ref "/specification/server/i18n" >}}) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Server | `locale` | | Provides [i18n support]({{< ref "/specification/server/i18n" >}}) |
| Server | `locale` | Provides [i18n support]({{< ref "/specification/server/i18n" >}}) |

@@ -14,4 +14,5 @@ Clients can implement additional features to enrich connected MCP servers:
{{< cards >}}
{{< card link="roots" title="Roots" icon="folder" >}}
{{< card link="sampling" title="Sampling" icon="annotation" >}}
{{< card link="i18n" title="I18n support" icon="globe-alt" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we use 'i18n' in other parts. Let's be consistent with upper/lowercase.

Suggested change
{{< card link="i18n" title="I18n support" icon="globe-alt" >}}
{{< card link="i18n" title="i18n support" icon="globe-alt" >}}

@@ -0,0 +1,11 @@
---
title: I18n support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we will start a new subdirectory for the draft of the next protocol version. We will have to move all files over. We should still mark these docs as PROPOSED

@jspahrsummers
Copy link
Member

jspahrsummers commented Jan 10, 2025

We've now created a separate place for the draft version of the spec, so we can move this there. Please tag us if you get a chance to tidy it up for inclusion into the draft. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internationalization (i18n) / multilingualism for some text fields ?
3 participants