Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup/fixes #17

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Cleanup/fixes #17

merged 5 commits into from
Jul 30, 2024

Conversation

wpbonelli
Copy link
Member

  • no descriptor protocol for now, maybe reintroduce later as __getattributes__ is a bit heavy-handed
  • miscellaneous code cleanup and docstring improvements
  • add value getters/setters to block/package classes
  • add classmethods to coerce params/blocks to spec
  • support equality comparisons for param/block/package
  • give scalar param subclasses a generic type parameter

@wpbonelli wpbonelli marked this pull request as ready for review July 30, 2024 03:59
@wpbonelli wpbonelli merged commit ae33a56 into modflowpy:develop Jul 30, 2024
14 checks passed
@wpbonelli wpbonelli deleted the cleanup branch July 30, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wpbonelli