Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#2092): upgrade nodeJS version for core services #67

Merged
merged 9 commits into from
May 19, 2022

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented May 18, 2022

feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092

  • standardised CI scripts
  • fixed lint issues
  • updated .nvmrc to latest LTS version
  • added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
  • updated gitignore to include test/results and IGNORE patterns
  • added useUnknownInCatchVariables config to tsconfig to support current code style
  • updated README with standard auto-release information
  • Fixed imports
  • Added 'serialize-error' to ncurc for dep:check to ignore future updates - this is because v9+ only supports ESM loaders and not CJS. This will need to be addressed in a future story.
  • Aligned jest config to moja standard
  • Cleaned up Package.json
  • Added 'prepublishOnly' script to package.json to ensure that dist is build prior to publishing
  • Updated tsconfig to latest standards

Notes:

  • npm-audit-resolver v3.0.0-7 is a candidate release to resolve compatibility with npm v7+ as described in Doesn't work with npm@7 and above [work almost finished, see @next tag on npm] naugtur/npm-audit-resolver#34. This will need to be addressed going forward as npm run audit:resolve (i.e. resolve-audit) is currently not functioning. As a work-around, we need to manually run the following command npm audit fix. The npm run audit:check (i.e. check-audit) still works as expected.
  • 'serialize-error' version is fixed to v8.1.0, this is because v9+ only supports ESM loaders and not CJS. This will need to be addressed in a future story.

BREAKING CHANGE: major version bump for node v16 LTS support, and re-structuring of project directories to align to core Mojaloop repositories!

mdebarros added 4 commits May 18, 2022 19:37
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092
- standardised CI scripts
- fixed lint issues
- updated .nvmrc to latest LTS version
- added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
- updated gitignore to include test/results and IGNORE patterns
- added useUnknownInCatchVariables config to tsconfig to support current code style
- updated README with standard auto-release information

Notes:
- npm-audit-resolver v3.0.0-7 is a candidate release to resolve compatibility with npm v7+ as described in naugtur/npm-audit-resolver#34. This will need to be addressed going forward as `npm run audit:resolve` (i.e. `resolve-audit`) is currently not functioning. As a work-around, we need to manually run the following command `npm audit fix`. The `npm run audit:check` (i.e. `check-audit`) still works as expected.

BREAKING CHANGE: major version bump for node v16 LTS support, and re-structuring of project directories to align to core Mojaloop repositories!
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092
- Fixed imports
- Added 'serialize-error' to ncurc for dep:check to ignore future updates - this is because v9+ only supports ESM loaders and not CJS. This will need to be addressed in a future story.
- Aligned jest config to moja standard
- Cleaned up Package.json
- Added 'prepublishOnly' script to package.json to ensure that dist is build prior to publishing
- Updated tsconfig to latest standards
@mdebarros mdebarros marked this pull request as ready for review May 19, 2022 08:32
@vijayg10 vijayg10 self-requested a review May 19, 2022 08:53
@mdebarros mdebarros merged commit 6fa9f74 into master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants