-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mojaloop/#2092): upgrade nodeJS version for core services #501
Merged
mdebarros
merged 56 commits into
mojaloop:master
from
mdebarros:feat/#2092-Upgrade-NodeJS-Version-for-core-services
May 23, 2022
Merged
feat(mojaloop/#2092): upgrade nodeJS version for core services #501
mdebarros
merged 56 commits into
mojaloop:master
from
mdebarros:feat/#2092-Upgrade-NodeJS-Version-for-core-services
May 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092 - standardised CI scripts - fixed lint issues - updated .nvmrc to latest LTS version - added standard CI scripts/config to package.json: release, snapshot, standard-version, etc - updated gitignore to include test/results and IGNORE patterns - updated README with standard auto-release information - Fixed imports - Cleaned up Package.json - updated links in CHAGNGELOG to correctly point to project repo Notes: - npm-audit-resolver v3.0.0-7 is a candidate release to resolve compatibility with npm v7+ as described in naugtur/npm-audit-resolver#34. This will need to be addressed going forward as `npm run audit:resolve` (i.e. `resolve-audit`) is currently not functioning. As a work-around, we need to manually run the following command `npm audit fix`. The `npm run audit:check` (i.e. `check-audit`) still works as expected. BREAKING CHANGE: major version bump for node v16 LTS support, and re-structuring of project directories to align to core Mojaloop repositories!
…er for tests to pass with related changes made to unit tests
mdebarros
requested review from
vgenev,
elnyry-sam-k,
lewisdaly,
oderayi,
shashi165 and
vijayg10
as code owners
May 23, 2022 12:40
elnyry-sam-k
approved these changes
May 23, 2022
GP tests executed against mojaloop/ml-api-adapter/v14.0.0-snapshot.15 release:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092
Notes:
npm run audit:resolve
(i.e.resolve-audit
) is currently not functioning. As a work-around, we need to manually run the following commandnpm audit fix
. Thenpm run audit:check
(i.e.check-audit
) still works as expected./opt/ml-api-adapter
to/opt/app
as follows:BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses
/opt/app
instead of/opt/ml-api-adapter
which will impact config/secret mounts.