Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#2092): upgrade nodeJS version for core services #501

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented May 20, 2022

feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092

  • standardised CI scripts
  • fixed lint issues
  • updated .nvmrc to latest LTS version
  • added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
  • updated gitignore to include test/results and IGNORE patterns
  • updated README with standard auto-release information
  • Fixed imports
  • Cleaned up Package.json
  • updated links in CHANGELOG to correctly point to project repo
  • Removed "secrets" (i.e. JWS Signing Keys) as we don't want anybody to accidentally use a "test" key. Rather have an error thrown and for people to explicitly configure their own keys. This does mean that I had to add a "dummy" (with no meaningful body) key file that is empty for unit tests to pass, and will have no impact on the docker image of the service (i.e. it will fail if JWS is enabled, and no Key is injected/configured).

Notes:

  • npm-audit-resolver v3.0.0-7 is a candidate release to resolve compatibility with npm v7+ as described in Doesn't work with npm@7 and above [work almost finished, see @next tag on npm] naugtur/npm-audit-resolver#34. This will need to be addressed going forward as npm run audit:resolve (i.e. resolve-audit) is currently not functioning. As a work-around, we need to manually run the following command npm audit fix. The npm run audit:check (i.e. check-audit) still works as expected.
  • 'get-port' dependency version is fixed to v5.1.1, this is because v9+ only supports ESM loaders and not CJS. This will need to be addressed in a future story.
  • Helm chart mountPaths need to be updated from /opt/ml-api-adapter to /opt/app as follows:
        volumeMounts:
        - mountPath: /opt/app/config
          name: <deployment-name>
        - mountPath: /opt/app/secrets <-- only required for the notification service
          name: jws-signing-key

BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses /opt/app instead of /opt/ml-api-adapter which will impact config/secret mounts.

mdebarros added 30 commits May 19, 2022 18:38
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092
- standardised CI scripts
- fixed lint issues
- updated .nvmrc to latest LTS version
- added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
- updated gitignore to include test/results and IGNORE patterns
- updated README with standard auto-release information
- Fixed imports
- Cleaned up Package.json
- updated links in CHAGNGELOG to correctly point to project repo

Notes:
- npm-audit-resolver v3.0.0-7 is a candidate release to resolve compatibility with npm v7+ as described in naugtur/npm-audit-resolver#34. This will need to be addressed going forward as `npm run audit:resolve` (i.e. `resolve-audit`) is currently not functioning. As a work-around, we need to manually run the following command `npm audit fix`. The `npm run audit:check` (i.e. `check-audit`) still works as expected.

BREAKING CHANGE: major version bump for node v16 LTS support, and re-structuring of project directories to align to core Mojaloop repositories!
…er for tests to pass with related changes made to unit tests
@mdebarros mdebarros marked this pull request as ready for review May 23, 2022 12:40
@mdebarros mdebarros self-assigned this May 23, 2022
@mdebarros
Copy link
Member Author

mdebarros commented May 23, 2022

GP tests executed against mojaloop/ml-api-adapter/v14.0.0-snapshot.15 release:

--------------------FINAL REPORT--------------------
Test Suite:GP Tests
Environment:moja2.test.mojaloop.live
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 2535                          │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 2535                          │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 0                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 577                           │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 128                           │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 100.00%                       │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Mon, 23 May 2022 16:14:12 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Mon, 23 May 2022 16:17:15 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 183119 ms                     │
└───────────────────┴───────────────────────────────┘

View Report

@mdebarros mdebarros merged commit bcf0b6d into mojaloop:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants