Limit daily requests for each user per channel #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dericksonmark
approved these changes
Jun 10, 2021
violine1101
requested changes
Jun 11, 2021
violine1101
approved these changes
Jun 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Close #166
Approach
Read from internal channels to get the requests that were created less than 24 hours before, limit per channel.
Negative request limits cause no limit for the channel.
Future work
This and the MentionDeleteEventHandler (#201) both read from the user tag, so if it is changed then it will no longer match the user, there needs to be another way around this. I added the functionality to update the user tag and icon whenever a request is updated, but that doesn't entirely fix it.