[Enhancement] Allow pulling config details from env vars #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
moleculekayak
commented
Aug 28, 2024
•
moleculekayak
commented
- Allows setting ENV vars in lieu of config JSON
- Added config validation
- Misc. refactors
* add env vars for api keys * allow mixing of config file and env var * change priority of env vars and config * remove accidental comment * correct output when loading configuration * simplify config loading output * refactor config class * change config default value to '' * fix typo * default bool option to false instead of none as it will get removed from dict anyway * handle case where INJECT_TORRENTS is unset * add config value validation at startup * reformat test * address review and finish validation * remove covid async hallucination * redistribute non-main functions --------- Co-authored-by: milkers69 <[email protected]>
moleculekayak
changed the title
moleculekayak
deleted the
mk/config-validation-env-vars-consolidation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.