Resolve SVG dimensions at runtime #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewberry
approved these changes
Feb 21, 2024
| return this.http | ||
| .get<BlockSet>(this.urls.get(blockSetId)!, httpOptions) | ||
| .pipe( | ||
| delayWhen((blockSet) => |
There was a problem hiding this comment.
btw, I'm probably not thinking it through, but why delayWhen instead of switchMap?
There was a problem hiding this comment.
oh! because the method needs to return a Observable<BlockSet>, and the inner observable is actually a Observable<SvgViewBox[]>. i just needed to wait for it to complete and then emit the original value (blockSet)
There was a problem hiding this comment.
I actually used switchMap and mergeMap in my original PR, but then I had second thoughts today and browsed through all available operators and found delayWhen which does exactly what I needed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.