feat(agent): DB persistence and node process disowning #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zander Franks <[email protected]>
… parent will kill the spawned command
|
We should be good to close this now since #231 is merged |
|
Wait, I forgot this PR was something else. It has some node process disowning stuff that I'm not sure if we want. We can keep the branch around but the PR closed for now |
@voximity @Meshiest and I were also considering just biting the bullet and using systemd since it'd be much easier. Branch might still be a good reference tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Isolate persisting agent-related data in the same type of database that the control plane uses. Future-proofing and easier to maintain.
End goal is to support zombifying nodes launched by the agent, so the node's process ID can be persisted and tracked, even if the agent is killed and restarted.
Explanation of Changes
TODO
Testing
TODO
Related PRs and Issues