added multiple models, along the lines of multiple languages. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functions are called twice, output goes into multilingual and multimodel within output and raw_results dirs. Two hardcoded model names in ontogpt have to be edited in order for this to work
Probably done once monarch-initiative/ontogpt#415 is merged. |
justaddcoffee
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several functions are called twice, output goes into multilingual dir and multimodel dir, present both within output and raw_results dirs. It is like a duplicated analysis, where multiple models are run for English only. This seems like a good first step.
Two hardcoded model name strings within ontogpt (its multilingual function) have to be edited in order for this to work. See
https://github.com/monarch-initiative/malco/blob/a805822ae49ab5a4bc6ed9a93f6bdc7b346b5a56/src/malco/run/run.py#L52-L56
Multiple models are added here:
https://github.com/monarch-initiative/malco/blob/a805822ae49ab5a4bc6ed9a93f6bdc7b346b5a56/src/malco/runner.py#L22-L23