Fix nested loadCategoryName ARN

[wolfsolver]

Close #2041

[guanlisheng]

seem irrelevant.

[wolfsolver]

taking a look to the dump seems that String builder try to build with null.

[guanlisheng]

it's an ANR issue, I think we should take care of the while loop, e.g. add a limit here

[wolfsolver]

Understand. There is same case maybe where parentid of category is category itself?
anyway add limit and prevent case of parentid = id

[guanlisheng]

Great if we could just add a limit and keep others unchanged? it will be usefully to nail down the issue

[wolfsolver]

Does make no sense, since while check null :) Since this issue is quite strage I suppose that there is a situation where parentid is equal to id, maybe due some upgrade or dirty dB. So is better to keep check in entity to prevent this at the root cause Il ven 3 gen 2025, 06:57 Gong Guan ***@***.***> ha scritto:

…

or just break out once the category iterator is null. --- a/app/src/main/java/com/money/manager/ex/transactions/EditTransactionCommonFunctions.java +++ b/app/src/main/java/com/money/manager/ex/transactions/EditTransactionCommonFunctions.java @@ -941,6 +941,8 @@ public class EditTransactionCommonFunctions { category = categoryRepository.load(category.getParentId()); if (category != null) this.categoryName = category.getName() + ":" + this.categoryName; + else + break; } } else { this.categoryName = null; — Reply to this email directly, view it on GitHub <#2051 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYOSSHQI2SUJSQCP6G7PO32IYREVAVCNFSM6AAAAABURCK5HWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRYG4ZDMOJZGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[guanlisheng]

self-assignment is one of the loop cases. protection would be fine in the while loop