EMF add subqueries tests #226
Open
+74
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaVEV
force-pushed
the
EMF-subquery-tests
branch
from
27ec33c to
77d6286
Compare
timgraham
reviewed
Jan 19, 2025
|
|
||
|
|
||
| class SubqueryExistsTest(TestCase): | ||
| def setUp(self): |
| @@ -123,3 +129,62 @@ class MyModel(models.Model): | |||
| self.assertEqual( | |||
| msg, "Embedded models cannot have relational fields (Target.key is a ForeignKey)." | |||
| ) | |||
|
|
|||
|
|
|||
| class SubqueryExistsTest(TestCase): | |||
| self.assertEqual(queryset.count(), 3) | ||
| self.assertQuerySetEqual(queryset, ["Book B", "Book C", "Book D"], lambda book: book.name) | ||
|
|
||
| def test_range_query(self): |
There was a problem hiding this comment.
Why in this class? Is it because the count() does an aggregation?
There was a problem hiding this comment.
this test could be put in a better place. Will move
| author__name=OuterRef("name"), author__address__city="Boston" | ||
| ) | ||
| queryset = Author.objects.filter(Exists(subquery)) | ||
|
|
There was a problem hiding this comment.
Please omit the blank lines.
|
|
||
| def test_in_subquery(self): | ||
| subquery = Author.objects.filter(age__gt=35).values("name") | ||
| queryset = Book.objects.filter(author__name__in=Subquery(subquery)).order_by("name") |
There was a problem hiding this comment.
As far as I tested, the Subquery wrapping of subquery is unnecessary.
There was a problem hiding this comment.
Mmh yes, don't remember why i added that
| address2 = Address.objects.create(city="Boston", state="MA", zip_code=20002) | ||
| author1 = Author.objects.create(name="Alice", age=30, address=address1) | ||
| author2 = Author.objects.create(name="Bob", age=40, address=address2) | ||
| book1 = Book.objects.create(name="Book A", author=author1) |
There was a problem hiding this comment.
It would be nice to title it "Book 1" rather than switching between letters and numbers.
| class SubqueryExistsTest(TestCase): | ||
| def setUp(self): | ||
| # Create test data | ||
| address1 = Address.objects.create(city="New York", state="NY", zip_code=10001) |
There was a problem hiding this comment.
Embedded models should be saved to the database in their own collection (i.e. no create()). #216 will prohibit it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.