Add tests for min dependencies and update test matrix for min and max server versions #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyclements
requested changes
Jan 15, 2025
.github/workflows/test-python.yml
Outdated
| - name: Start MongoDB on MacOS | ||
| if: ${{ startsWith(runner.os, 'macOS') }} | ||
| run: | | ||
| brew tap mongodb/brew | ||
| brew install mongodb/brew/mongodb-community@${MONGODB_VERSION} | ||
| brew services start mongodb-community@${MONGODB_VERSION} | ||
| brew install mongodb/brew/[email protected] |
There was a problem hiding this comment.
This is the highest version supported on brew right now, but not the highest available with the GitHub action on Ubuntu.
There was a problem hiding this comment.
Actually, I must have had it misconfigured before, it works with 8.0.
.github/workflows/test-python.yml
Outdated
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
| enable-cache: true | ||
| python-version: "3.9" |
There was a problem hiding this comment.
Similar to comment about ${MONGODB_VERSION} => 7.0,
MIN_PYTHON_VERSION: "3.9", MONGODB_VERSION: "4.0" seem like a good idea. What am I missing?
caseyclements
approved these changes
Jan 15, 2025
blink1073
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run tests against minimum python packages and supported MongoDB version. Also test against the latest MongoDB version.