Migrate Lazy Initialization from Once_Cell to Std #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gifted-s thanks for the PR! We'll take a look at this soon. With Rust 1.80, LazyLock and LazyCell are now mainline so we may end up going with that. |
|
Thanks @terakilobyte!, I saw the update from 1.80. I will update accordingly |
Gifted-s
force-pushed
the
update_static_initilization
branch
from
9012e04 to
9801185
Compare
|
@terakilobyte This change is meant to be merged after the upgrade to Rust 1.80. I will make the change to other crates once this is merged. |
Gifted-s
changed the title
|
@Gifted-s This looks great! I am in favor of merging this, but I think we have to do some administration with regards to external PRs :) |
|
@pmeredit Thanks. |
|
@pmeredit I am open to any administrative process, let me know. |
|
Hi @pmeredit, do I need to sign a CLA to contribute? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
According to the official stable Rust 1.80.0 release. we now have LazyLock and LazyCell as part of the Standard Library(https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html). This PR upgrades all the
once_cell::sync::Lazytostd::sync::LazyLockto ensure the code is current.Why?
Warning
This should only be merged after upgrading to
Rust 1.80.0otherwise the merge will introduce a breaking changeChecklist