Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Engagement #2044

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Automatic Engagement #2044

wants to merge 5 commits into from

Conversation

Txus5012
Copy link
Contributor

@Txus5012 Txus5012 commented May 18, 2024

Adds a setting to allow the automatic addition of the Engaged effect after a melee attack (weapon or trait). It is added after resolving the opposed test.
Disabled by default.

Automatic Engagement

@silentmark
Copy link
Contributor

@Txus5012 don't you have problems with lack of permissions for actors if one of them is not GM?

I have my own implementation, with additional remove condition on move https://github.com/silentmark/wfrp4e-pl-addons/blob/main/scripts/auto-engaged.mjs

@Txus5012
Copy link
Contributor Author

Txus5012 commented May 18, 2024

If both actors are owned by players, I see.

I wouldn't remove it on move, because they can still move around their opponent (or at least many GMs understand so).

@silentmark
Copy link
Contributor

This part is being handled

@Txus5012
Copy link
Contributor Author

To avoid the lack of permissions issue, I made the attacker add it's own engaged in the attack test (if there is any target) and the defender add it's own engaged in the opposed test. This makes the process look a bit different.

Automatic Engagement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants