use electron-prebuilt@^0.36.4, node >= 4

[ungoldman]

Hi friends!

I encountered a show-stopping error when running npm start with newer node (>= 4). Saw this in electron JS console.

Uncaught Error: Module version mismatch. Expected 46, got 47.

Using latest electron-prebuilt and node >= 4 seemed to take care of the issue.

I bumped electron-prebuilt to latest and set engines in package.json to:

"engines": {
  "node": ">=4",
  "npm": ">=2.8.3"
}

Adjusted docs to reflect the change and ran fixpack for good measure.

Getting things in order to take a crack at another sprint for #151.

@moose-team/owners please take a look and let me know if it's alright to forge ahead.

[max-mapper]

+1

[beaugunderson]

i see --target=0.34.2 in rebuild-leveld, that should be updated too yes?

[max-mapper]

oh yea it should. we should automate that....

On Wed, Jan 20, 2016 at 12:55 PM, Beau Gunderson [email protected]
wrote:

i see --target=0.34.2 in rebuild-leveld, that should be updated too yes?

—
Reply to this email directly or view it on GitHub
#153 (comment).

[ungoldman]

Good catch @beaugunderson, I'll add that to this PR

[ungoldman]

Last commit takes electron version from package.json for both rebuild-leveldb script and electron-packager (pkg.js) script. @beaugunderson @maxogden let me know if that looks alright to you.

Was thinking of integrating https://github.com/moose-team/friends/pull/140/files#diff-fd4c3053b5f27a8826f2c5c106cb6adfR32 and https://github.com/moose-team/friends/pull/140/files#diff-fd4c3053b5f27a8826f2c5c106cb6adfR37 into this too to close #140.

[feross]

Nice, LGTM!

[max-mapper]

nice work @ngoldman

[beaugunderson]

👍

[ungoldman]

Looks like windows is having trouble with $(../../version.js) (#154) -- should I revert this PR for now?

[lmatteis]

Shouldn't this fix it? https://github.com/atom/electron/blob/master/docs/tutorial/using-native-node-modules.md